Skip to content

Conversation

@tillig
Copy link
Member

@tillig tillig commented Mar 12, 2024

PR is waiting on this Autofac.Multitenant PR to get some updates on the nullable annotations.


Fixes #50

  • Update semver from 7.x => 8.0.0 to account for the breaking Autofac change coming.
  • Add support for .NET 8.
  • Drop support for .NET 3.1.
  • Update dependencies:
    • Autofac.Extensions.DependencyInjection => 9.0.0
    • Autofac.Multitenant => 8.0.2
  • Change the sandbox app to not specify a range of versions - just .NET 6 right now. If we have one sandbox app per .NET version, it will be cleaner to add/remove versions - we won't have to rename things. (This caused a lot of churn in this PR.)
  • Fix analyzer warnings based on the addition of .NET 8.
  • Switch from Moq to NSubstitute.

@codecov
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3f32a8f) to head (5e8dc65).

Additional details and impacted files
@@             Coverage Diff              @@
##           develop       #51      +/-   ##
============================================
+ Coverage    97.14%   100.00%   +2.85%     
============================================
  Files            6         6              
  Lines           70        67       -3     
  Branches         7         4       -3     
============================================
- Hits            68        67       -1     
+ Misses           1         0       -1     
+ Partials         1         0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tillig tillig marked this pull request as ready for review March 12, 2024 18:28
@tillig tillig requested a review from alistairjevans March 12, 2024 18:29
Copy link
Member

@alistairjevans alistairjevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, full disclosure havent looked in great detail at all the sandbox updates, but look ok on the surface.

@tillig tillig merged commit bf9604f into develop Mar 12, 2024
@tillig tillig deleted the feature/autofac-8 branch March 12, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support to .NET 8

3 participants