Skip to content

[DebugPackage] Fetch All Logs #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajanikow merged 1 commit into from
Jul 22, 2025
Merged

[DebugPackage] Fetch All Logs #1940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
- (Bugfix) (Platform) Prevent NPE in case of missing Helm Release
- (Bugfix) Align JWT Discovery
- (Feature) Compact Action
- (DebugPackage) Fetch All logs

## [1.2.50](https://github.com/arangodb/kube-arangodb/tree/1.2.50) (2025-07-04)
- (Feature) (Platform) MetaV1 Integration Service
Expand Down
12 changes: 0 additions & 12 deletions pkg/debug_package/generators/kubernetes/kubernetes_core_pods.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@ func kubernetesCorePodLogs(ctx context.Context, logger zerolog.Logger, client kc

if s := item.Status.ContainerStatuses; len(s) > 0 {
for id := range s {
if s[id].State.Waiting != nil {
continue
}

files <- kubernetesCorePodLogsExtract(ctx, client, item, s[id].Name)
Copy link

Copilot AI Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attempting to extract logs from containers in waiting state may result in API errors or empty responses. The Kubernetes API typically returns errors when trying to get logs from containers that haven't started yet. Consider adding error handling or checking if the container has actually started before attempting log extraction.

Copilot uses AI. Check for mistakes.

if s[id].RestartCount > 0 {
Expand All @@ -54,10 +50,6 @@ func kubernetesCorePodLogs(ctx context.Context, logger zerolog.Logger, client kc

if s := item.Status.EphemeralContainerStatuses; len(s) > 0 {
for id := range s {
if s[id].State.Waiting != nil {
continue
}

files <- kubernetesCorePodLogsExtract(ctx, client, item, s[id].Name)

if s[id].RestartCount > 0 {
Expand All @@ -68,10 +60,6 @@ func kubernetesCorePodLogs(ctx context.Context, logger zerolog.Logger, client kc

if s := item.Status.InitContainerStatuses; len(s) > 0 {
for id := range s {
if s[id].State.Waiting != nil {
continue
}

files <- kubernetesCorePodLogsExtract(ctx, client, item, s[id].Name)

if s[id].RestartCount > 0 {
Expand Down