[DebugPackage] Fetch All Logs #1940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwierzbo
approved these changes
Jul 21, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the debug package to fetch logs from all Kubernetes containers regardless of their current state by removing the waiting state checks. Previously, containers in a waiting state were skipped during log collection.
- Removes conditional checks that skip containers in waiting state
- Ensures comprehensive log collection for debugging purposes across all container types
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/debug_package/generators/kubernetes/kubernetes_core_pods.go | Removes waiting state checks for container, ephemeral container, and init container statuses to enable log collection from all containers |
| CHANGELOG.md | Documents the new debug package feature for fetching all logs |
| continue | ||
| } | ||
|
|
||
| files <- kubernetesCorePodLogsExtract(ctx, client, item, s[id].Name) |
There was a problem hiding this comment.
Attempting to extract logs from containers in waiting state may result in API errors or empty responses. The Kubernetes API typically returns errors when trying to get logs from containers that haven't started yet. Consider adding error handling or checking if the container has actually started before attempting log extraction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.