Skip to content

Fix BigQueryIO File load validate runtime value provider #36564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abacn merged 2 commits into from
Oct 20, 2025
Merged

Fix BigQueryIO File load validate runtime value provider #36564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60c213c
Fix BigQuerrIO File load validate runtime value provider
Abacn Oct 20, 2025
5ea04f1
Dedup test case
Abacn Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...o/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BatchLoads.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,14 +285,17 @@ public void validate(@Nullable PipelineOptions maybeOptions) {
PipelineOptions options = Preconditions.checkArgumentNotNull(maybeOptions);
// We will use a BigQuery load job -- validate the temp location.
String tempLocation;
if (customGcsTempLocation == null || customGcsTempLocation.get() == null) {
if (customGcsTempLocation == null) {
tempLocation = options.getTempLocation();
} else {
if (!customGcsTempLocation.isAccessible()) {
// Can't perform verification in this case.
return;
} else if (Strings.isNullOrEmpty(customGcsTempLocation.get())) {
Copy link
Contributor

@liferoad liferoad Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarun-google we should add one test later to capture this case.

Copy link
Contributor Author

@Abacn Abacn Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried to add one using RuntimeValueProvider, however using pipeline.newProvider(...) in unit test makes the value provider still accessible at compile time. Looks like one needs a pipeline proto (Dataflow templates) to test the case

Copy link
Contributor

@tarun-google tarun-google Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The base implementation itself is a bit odd, It needs pipelineoptions from inputPTransform, which is busted(#33074), and then backs off to pipelineoptions from context during runtime.

tempLocation = options.getTempLocation();
} else {
tempLocation = customGcsTempLocation.get();
}
tempLocation = customGcsTempLocation.get();
}
checkArgument(
!Strings.isNullOrEmpty(tempLocation),
Expand Down
2 changes: 2 additions & 0 deletions ...cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOWriteTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4444,6 +4444,8 @@ public void testUpsertAndDeleteBeamRows() throws Exception {

@Test
public void testCustomGcsTempLocationNull() throws Exception {
assumeTrue(!useStreaming);
assumeTrue(!useStorageApi);
BigQueryIO.Write<TableRow> write =
BigQueryIO.writeTableRows()
.to("dataset-id.table-id")
Expand Down
Loading