Skip to content

Conversation

@Abacn
Copy link
Contributor

@Abacn Abacn commented Oct 20, 2025

context: GoogleCloudPlatform/DataflowTemplates#2892 (comment)

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Abacn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue within the BigQuery I/O connector's validation process for file loads. It specifically enhances the conditional check for the custom GCS temporary location, ensuring that the associated ValueProvider is properly checked for accessibility before attempting to retrieve its value, thus preventing potential runtime exceptions during pipeline execution.

Highlights

  • BigQuery I/O Validation Fix: Corrected the validation logic for the customGcsTempLocation in BatchLoads.java to ensure that the ValueProvider.get() method is only invoked after verifying that the ValueProvider is accessible. This prevents potential runtime errors when the value is not yet available.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Abacn Abacn changed the title Fix BigQuerrIO File load validate runtime value provider Fix BigQueryIO File load validate runtime value provider Oct 20, 2025
@liferoad liferoad added this to the 2.69.0 Release milestone Oct 20, 2025
if (!customGcsTempLocation.isAccessible()) {
// Can't perform verification in this case.
return;
} else if (Strings.isNullOrEmpty(customGcsTempLocation.get())) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarun-google we should add one test later to capture this case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried to add one using RuntimeValueProvider, however using pipeline.newProvider(...) in unit test makes the value provider still accessible at compile time. Looks like one needs a pipeline proto (Dataflow templates) to test the case

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The base implementation itself is a bit odd, It needs pipelineoptions from inputPTransform, which is busted(#33074), and then backs off to pipelineoptions from context during runtime.

@tarun-google
Copy link
Contributor

LGTM

@Abacn Abacn merged commit e081879 into apache:master Oct 20, 2025
16 of 17 checks passed
@Abacn Abacn deleted the fix-validate-bq branch October 20, 2025 18:01
Amar3tto pushed a commit that referenced this pull request Oct 20, 2025
* Fix BigQuerrIO File load validate runtime value provider

* Dedup test case
Amar3tto added a commit that referenced this pull request Oct 20, 2025
[Release-2.69] Cherry-pick #36564 into release branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants