-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Fix BigQueryIO File load validate runtime value provider #36564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Abacn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue within the BigQuery I/O connector's validation process for file loads. It specifically enhances the conditional check for the custom GCS temporary location, ensuring that the associated Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
61b6d5b to
60c213c
Compare
| if (!customGcsTempLocation.isAccessible()) { | ||
| // Can't perform verification in this case. | ||
| return; | ||
| } else if (Strings.isNullOrEmpty(customGcsTempLocation.get())) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tarun-google we should add one test later to capture this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tried to add one using RuntimeValueProvider, however using pipeline.newProvider(...) in unit test makes the value provider still accessible at compile time. Looks like one needs a pipeline proto (Dataflow templates) to test the case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The base implementation itself is a bit odd, It needs pipelineoptions from inputPTransform, which is busted(#33074), and then backs off to pipelineoptions from context during runtime.
|
LGTM |
* Fix BigQuerrIO File load validate runtime value provider * Dedup test case
[Release-2.69] Cherry-pick #36564 into release branch
context: GoogleCloudPlatform/DataflowTemplates#2892 (comment)
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.