Skip to content

i fixed the unexpected cfg condition value: bpf-entrypoint #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
victorchukwuemeka wants to merge 1 commit into
base: main
Choose a base branch
from
Open

i fixed the unexpected cfg condition value: bpf-entrypoint #293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ alloc = ["solana-instruction-view?/slice-cpi"]
copy = ["solana-account-view/copy", "solana-address/copy"]
cpi = ["dep:solana-instruction-view"]
default = ["alloc"]
bpf-entrypoint = []
Copy link
Collaborator

@febo febo Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not add the feature to the crate since it is not used here. It will be misleading to have it.

Copy link
Author

@victorchukwuemeka victorchukwuemeka Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning was thier when I ran the test, after i added the feature, everything was resolved . Currently, if I run the test from my end, there is no warning message

Copy link
Author

@victorchukwuemeka victorchukwuemeka Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the warning IMG-20251204-WA0000.jpg

Copy link
Author

@victorchukwuemeka victorchukwuemeka Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After adding the feature
IMG-20251204-WA0002.jpg

Copy link
Collaborator

@febo febo Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I think I found the source of it. There are two doctests that are "tagged" with no_run: here and here.

The best way to prevent the warning this is to add:

//! # #![allow(unexpected_cfgs)]

just before the line:

//! #[cfg(feature = "bpf-entrypoint")]

Copy link
Author

@victorchukwuemeka victorchukwuemeka Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let me add it now

Copy link
Author

@victorchukwuemeka victorchukwuemeka Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it, and the warning came back again

Copy link
Collaborator

@febo febo Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which rust version are you using?

Copy link
Author

@victorchukwuemeka victorchukwuemeka Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is my version
rustc 1.84.1 (e71f9a9a9 2025-01-27)

Copy link
Author

@victorchukwuemeka victorchukwuemeka Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@febo good day i will love the pr to be reviewed and i also want to contribute in any task that you can ask of


[dependencies]
solana-account-view = { workspace = true }
Expand Down