-
Notifications
You must be signed in to change notification settings - Fork 172
i fixed the unexpected cfg condition value: bpf-entrypoint #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
i fixed the unexpected cfg condition value: bpf-entrypoint #293
Conversation
|
@victorchukwuemeka alternatively you can add the next rules to the workspace [workspace.lints.rust.unexpected_cfgs]
level = "warn"
check-cfg = [
'cfg(target_os, values("solana"))',
'cfg(feature, values("no-entrypoint"))',
] |
| copy = ["solana-account-view/copy", "solana-address/copy"] | ||
| cpi = ["dep:solana-instruction-view"] | ||
| default = ["alloc"] | ||
| bpf-entrypoint = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not add the feature to the crate since it is not used here. It will be misleading to have it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The warning was thier when I ran the test, after i added the feature, everything was resolved . Currently, if I run the test from my end, there is no warning message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, let me add it now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried it, and the warning came back again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which rust version are you using?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is my version
rustc 1.84.1 (e71f9a9a9 2025-01-27)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@febo good day i will love the pr to be reviewed and i also want to contribute in any task that you can ask of



Summary
Adds the missing
bpf-entrypointfeature to the SDK's Cargo.toml.Problem
The documentation examples in
src/entrypoint/mod.rsandsrc/entrypoint/lazy.rsreference abpf-entrypointfeature that didn't exist in Cargo.toml, causing doctest warnings:Solution
Added
bpf-entrypoint = []to the[features]section insdk/Cargo.toml.Testing
cargo test --workspacepasses without warnings