This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
Persisting font size between Brackets Sessions #3027
Merged
Merged
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
db25a99
Cleaned up whitespace and indents
lkcampbell 296d68c
Rewrite _adjustFontSize() so it can adjust font size by more than a s…
lkcampbell ea275c0
Add in persistence of font size between Brackets sessions
lkcampbell 0a3d153
Limit the maximum negative value of fontSizeAdjustment so the fonts d…
lkcampbell 52635b1
Persisted font sizes now load on currentDocumentChange event
lkcampbell 7b09947
Disable Font Size commands when there is no current document
lkcampbell c307c31
Update UI appropriately when the application first starts and when th…
lkcampbell 22cfba5
Small comment change
lkcampbell ab1f316
Small comment change (again)
lkcampbell 7a73f36
Small comment change (Part III)
lkcampbell a26923d
Merge remote-tracking branch 'upstream/master' into persist_font_size
lkcampbell 382af79
Add whitespace back in again
lkcampbell 13ee760
Add in limit on max font size
lkcampbell f3ac742
Fixed JSLint errors
lkcampbell 6c4cf98
Add in license whitespace
lkcampbell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some difficulties in understanding this line. At first, I thought you have "+ 1" by mistake (thinking that you copied this line of code from somewhere else and forgot to remove this part). Later, your comment above this line helped me to realize that your are reverting the exact action done by the caller. So instead of having to know what the caller has done and having to revert the same action here, why don't we make the following changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me. Did we ever agree what that upper bound is going to be or do you want me to pick an arbitrary value and we can tweak it from there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe no one has suggested the upper bound value. So you have the power to make that decision.