Skip to content

fix: List item enter handler applying to custom blocks #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

matthewlipski
Copy link
Collaborator

Closes #558

Copy link

vercel bot commented Feb 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Mar 14, 2024 2:27pm
blocknote-website ✅ Ready (Inspect) Visit Preview Mar 14, 2024 2:27pm

@troglodytto
Copy link

troglodytto commented Feb 20, 2024

@matthewlipski What if we do want this behaviour to persist in a custom Block?
https://discord.com/channels/928190961455087667/1209559379095855154

@matthewlipski
Copy link
Collaborator Author

@matthewlipski What if we do want this behaviour to persist in a custom Block? https://discord.com/channels/928190961455087667/1209559379095855154

That's fair, though it should still be possible to add that functionality even with this PR - see the replies in the thread. However, I don't think that having your block end in listItem is a good API for it, so I think we should still go ahead with this PR.

@matthewlipski matthewlipski changed the title fix: List item enter shortcut applying to custom blocks fix: List item enter handler applying to custom blocks Mar 14, 2024
@matthewlipski matthewlipski merged commit 444c009 into main Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"ListItem" is hardcoded.
3 participants