Skip to content

"ListItem" is hardcoded. #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hyuckkim opened this issue Feb 2, 2024 · 1 comment · Fixed by #571
Closed

"ListItem" is hardcoded. #558

hyuckkim opened this issue Feb 2, 2024 · 1 comment · Fixed by #571
Labels
prio:high High priority

Comments

@hyuckkim
Copy link

hyuckkim commented Feb 2, 2024

if (!contentType.name.endsWith("ListItem") || !selectionEmpty) {

I cannot how it works, but It works in custom block also.
I changed my custom block's type to JohnDoeListItem and use their feature.

I think it need to allow modification to boolean values in blockspec.

@matthewlipski matthewlipski added the prio:high High priority label Feb 12, 2024
@matthewlipski
Copy link
Collaborator

Good point, didn't consider custom list item blocks which maybe shouldn't have the same behaviour as the default ones, will fix to only use the shortcut for BulletListItem and NumberedListItem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio:high High priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants