Skip to content

Conversation

@MaEtUgR
Copy link
Member

@MaEtUgR MaEtUgR commented Oct 15, 2025

Solved Problem

When checking 1.16 backport prs (https://github.com/PX4/PX4-Autopilot/pulls?q=is%3Apr+is%3Aopen+1.16) I found that ci is failing because #25739

Solution

Backport it 1:1. It's very low risk, doesn't impact the PX4 build at all but will make ci pass on any prs to 1.16 based branches.

Changelog Entry

ci: Pin emscripten to a version that doesn't warn -> error without C++ 17

Test coverage

It works as expected on main and also on another internal branch where I had this problem and ci should then also pass on this pr.

@MaEtUgR MaEtUgR requested a review from mrpollo October 15, 2025 15:43
@MaEtUgR MaEtUgR self-assigned this Oct 15, 2025
@MaEtUgR
Copy link
Member Author

MaEtUgR commented Oct 15, 2025

Why don't I get a CI build for image like e.g. is failing in #25736 ?

@mrpollo
Copy link
Contributor

mrpollo commented Oct 15, 2025

Because the CI action will only run under the following conditions

on:
  push:
    branches:
    - 'main'
    paths-ignore:
      - 'docs/**'
      - '.github/**'
  pull_request:
    branches:
      - '**'
    paths-ignore:
      - 'docs/**'
      - '.github/**'

@dagar
Copy link
Member

dagar commented Oct 15, 2025

Why don't I get a CI build for image like e.g. is failing in #25736 ?

The github action configuration.

branches:
- 'main'

Annoyingly this produces slightly different results for people that push to the main repo then open a pull request vs someone that opens a pull request from a fork.

@dagar dagar merged commit 09eda9e into release/1.16 Oct 15, 2025
33 checks passed
@dagar dagar deleted the fix_failsafe_sim-1.16 branch October 15, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants