Skip to content

[BACKPORT 1.16] mavlink: add message spacing for AVAILABLE_MODES, for low bandwidth #25662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dakejahl merged 1 commit into from
Oct 1, 2025
Merged

[BACKPORT 1.16] mavlink: add message spacing for AVAILABLE_MODES, for low bandwidth #25662

dakejahl merged 1 commit into from
Oct 1, 2025

Conversation

@dakejahl
Copy link
Contributor

@dakejahl dakejahl commented Sep 28, 2025

backport #25428

@alexcekay @bkueng @dakejahl
mavlink: add message spacing for AVAILABLE_MODES, for low bandwidth
23a9e76 
* mavlink: add message spacing for AVAILABLE_MODES, for low bandwidth links

* calculate delay based on rate

* fixed transmit time calc & not delay single mode send

Co-authored-by: bkueng <[email protected]>

---------

Co-authored-by: bkueng <[email protected]>
@github-actions
Copy link

github-actions bot commented Sep 28, 2025

🔎 FLASH Analysis

px4_fmu-v5x [Total VM Diff: 72 byte (0 %)] 
    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%     +72  +0.0%     +72    .text
  +0.1%     +88  +0.1%     +88    src/modules/mavlink/modules__mavlink_unity.cpp
  +0.2%      +3  +0.2%      +3    ../../src/systemcmds/ver/ver.cpp
  -0.0%      -8  -0.0%      -8    ROMFS/nsh_romfsimg.c
  -0.0%     -11  -0.0%     -11    [section .text]
+0.0%     +80  [ = ]       0    .debug_abbrev
   +11%     +56  [ = ]       0    ../../src/lib/version/version.c
  +0.3%     +24  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
-0.0%      -8  [ = ]       0    .debug_aranges
  -5.0%      -8  [ = ]       0    ../../src/lib/version/version.c
+0.0%      +4  [ = ]       0    .debug_frame
+0.0%    +163  [ = ]       0    .debug_info
  -0.2%      -4  [ = ]       0    ../../src/lib/version/version.c
  +0.0%    +167  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
+0.0%     +77  [ = ]       0    .debug_line
  -1.3%     -25  [ = ]       0    ../../src/lib/version/version.c
  +0.1%    +101  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
  +0.1%      +1  [ = ]       0    task/task_cancelpt.c
+0.0%    +282  [ = ]       0    .debug_loc
  +0.1%    +282  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
+0.0%     +17  [ = ]       0    .debug_ranges
  -2.6%      -8  [ = ]       0    ../../src/lib/version/version.c
  +0.1%     +24  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
  +1.5%      +1  [ = ]       0    task/task_cancelpt.c
+0.0%     +53  [ = ]       0    .debug_str
  +0.0%     +53  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
+1.4%      +3  [ = ]       0    .shstrtab
+0.0%      +1  [ = ]       0    .strtab
  -8.1%     -32  [ = ]       0    ../../src/lib/version/version.c
  +0.1%     +32  [ = ]       0    [section .strtab]
  +0.0%      +1  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
-0.1%     -72  [ = ]       0    [Unmapped]
+0.0%    +672  +0.0%     +72    TOTAL
px4_fmu-v6x [Total VM Diff: 72 byte (0 %)] 
    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%     +72  +0.0%     +72    .text
  +0.1%     +88  +0.1%     +88    src/modules/mavlink/modules__mavlink_unity.cpp
  -0.0%      -7  -0.0%      -7    ROMFS/nsh_romfsimg.c
  -0.0%      -9  -0.0%      -9    [section .text]
+0.0%     +80  [ = ]       0    .debug_abbrev
   +11%     +56  [ = ]       0    ../../src/lib/version/version.c
  +0.3%     +24  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
-0.0%      -8  [ = ]       0    .debug_aranges
  -5.0%      -8  [ = ]       0    ../../src/lib/version/version.c
+0.0%      +4  [ = ]       0    .debug_frame
+0.0%    +163  [ = ]       0    .debug_info
  -0.2%      -4  [ = ]       0    ../../src/lib/version/version.c
  +0.0%    +167  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
+0.0%     +77  [ = ]       0    .debug_line
  -1.3%     -25  [ = ]       0    ../../src/lib/version/version.c
  +0.1%    +101  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
  +0.1%      +1  [ = ]       0    task/task_cancelpt.c
+0.0%    +282  [ = ]       0    .debug_loc
  +0.1%    +282  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
+0.0%     +17  [ = ]       0    .debug_ranges
  -2.6%      -8  [ = ]       0    ../../src/lib/version/version.c
  +0.1%     +24  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
  +1.6%      +1  [ = ]       0    task/task_cancelpt.c
+0.0%     +53  [ = ]       0    .debug_str
  +0.0%     +53  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
-0.5%      -1  [ = ]       0    .shstrtab
+0.0%      +1  [ = ]       0    .strtab
  -8.1%     -32  [ = ]       0    ../../src/lib/version/version.c
  +0.0%     +32  [ = ]       0    [section .strtab]
  +0.0%      +1  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
-0.1%     -72  [ = ]       0    [Unmapped]
+0.0%    +668  +0.0%     +72    TOTAL

Updated: 2025-09-28T01:21:23

@dakejahl dakejahl requested a review from alexcekay September 30, 2025 23:16
@DronecodeBot
Copy link

DronecodeBot commented Oct 1, 2025

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-dev-call-oct-1-2025-team-sync-and-community-q-a/47561/1

@dakejahl dakejahl merged commit 089887f into release/1.16 Oct 1, 2025
90 of 94 checks passed
@dakejahl dakejahl deleted the backport_1.16/pr-available-modes-throttle branch October 1, 2025 21:25
@farhangnaderi farhangnaderi moved this from Todo to In Progress in PX4 v1.17 Release Oct 8, 2025
@farhangnaderi farhangnaderi moved this from In Progress to Done in PX4 v1.17 Release Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcekay alexcekay alexcekay approved these changes

Assignees

No one assigned

Labels

None yet

Projects

PX4 v1.17 Release
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dakejahl @DronecodeBot @alexcekay