Loiter at the last mission waypoint on mission end #25618
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Solved Problem
When the final mission waypoint is reached, the navigator sets the loiter position setpoint to the current position instead of the mission’s intended waypoint.
As a result, the vehicle ends up loitering at the position where it entered the waypoint’s acceptance radius, instead at the waypoint itself.
Solution
On mission end, call
setLoiterItemFromCurrentPositionSetpoint()if current position setpoint is of typeSETPOINT_TYPE_POSITION