[Backport 1.16] of fix: let UXRCE DDS agent IP to be set via parameter in SITL (#25231) #25299
Conversation
* Read XRCE_DDS IP from ENV * just remove the -h flag from the launch command * add 127.0.0.1 as default IP * add default value for IP
|
@beniaminopozzan the failing build seems unrelated, is there any way to retrigger this? |
sansha
changed the title
sansha
force-pushed
the
release/1.16-backport-#25231
branch
from
b9826cf to
1261caa
Compare
|
@beniaminopozzan I just removed the empty commits to make the history clean, saw CI failing in the same place also on other PRs. I think this is ready whenever you have time :) Thanks! |
|
Thanks for the contribution. This seems worthwhile, although a bit late for the release. Regarding the CI test, I made this PR to fix the issue. I'll make sure we bring this in as soon as we get it passing #25344. |
|
@mrpollo awesome, thank you so much! let me know when I can help with anything |
|
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: https://discuss.px4.io/t/px4-dev-call-aug-06-2025-team-sync-and-community-q-a/46826/1 |
3 participants
Backporting #25231 into the 1.16 release. Thank you!
Solved Problem
When ... I found that ...
Fixes #{Github issue ID}
Solution
Changelog Entry
For release notes:
Alternatives
We could also ...
Test coverage
Context
Related links, screenshot before/after, video