Skip to content

Fix issue where XRCE_DDS Bridge did not respect environment variables #25231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beniaminopozzan merged 5 commits into from
Jul 25, 2025
Merged

Fix issue where XRCE_DDS Bridge did not respect environment variables #25231

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
59a751d
Read XRCE_DDS IP from ENV
sansha Jul 16, 2025
741e51d
just remove the -h flag from the launch command
sansha Jul 16, 2025
0a0904f
add 127.0.0.1 as default IP
sansha Jul 25, 2025
a50c492
add default value for IP
sansha Jul 25, 2025
975722e
Merge branch 'main' into fix-xrce-dds-bridge-not-using-env-ip
sansha Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ROMFS/px4fmu_common/init.d-posix/rcS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,9 @@ param set-default SYS_FAILURE_EN 1
# does not go below 50% by default, but failure injection can trigger failsafes.
param set-default COM_LOW_BAT_ACT 3

# set default IP to localhost
param set-default UXRCE_DDS_AG_IP 2130706433 # 127.0.0.1


# Adapt timeout parameters if simulation runs faster or slower than realtime.
if [ -n "$PX4_SIM_SPEED_FACTOR" ]; then
Expand Down Expand Up @@ -319,7 +322,7 @@ then
uxrce_dds_port="$PX4_UXRCE_DDS_PORT"
fi

uxrce_dds_client start -t udp -h 127.0.0.1 -p $uxrce_dds_port $uxrce_dds_ns
uxrce_dds_client start -t udp -p $uxrce_dds_port $uxrce_dds_ns

if param greater -s MNT_MODE_IN -1
then
Expand Down
Loading