[BACKPORT v1.15] gps: heading fixes for NMEA/Unicore #24092
Conversation
|
This seems to include a few minor other changes for GPS but I believe that should be beneficial. |
|
Flight tested with Unicore, worked as expected including GPS heading. |
This updates the GPS submodule which includes NMEA/Unicore fixes: - Add correct return value for sat infos - Only publish on position updates - Request required topics at 5 Hz for Unicore
mrpollo
force-pushed
the
pr-backport-1.15-nmea-unicore-updates
branch
from
2b278f8 to
787730a
Compare
|
@julianoes going to test this on FW - anything special you did? I'l like to turn off all compasses. Any objections to that your do you need to keep one on (I'm sure we'll be able to give some intelligent insight after some testing). the objective is magless operation but also steady enough heading for runway takeoff. |
* gps: heading fixes for NMEA/Unicore This updates the GPS submodule which includes NMEA/Unicore fixes: - Add correct return value for sat infos - Only publish on position updates - Request required topics at 5 Hz for Unicore * gps: build fix
|
I'm not sure honestly but a test flight is worthwhile even if you leave mag enabled as the GPS heading and the EKF flags will be in the log. |
|
Maybe to take this a little bit more pragmatically I’ll put it on there do a test flight and we can compare the two so we’ve got some high-quality mag data and we can compare it against what is actually happening with this on board as well |
Backport of #24077.
Needs testing.