ackermann: added delay comand support #23445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stop rover if in acceptance radius of waypoint to avoid spinning around if there is a delay
sbtjagu
force-pushed
the
delay_command_support
branch
from
6635cf6 to
7053264
Compare
Contributor
chfriedrich98
left a comment
chfriedrich98
left a comment
There was a problem hiding this comment.
Looks good, thanks for implementing this feature!
I just have some small changes to adress.
src/modules/rover_ackermann/RoverAckermannGuidance/RoverAckermannGuidance.cpp
Outdated
Show resolved
Hide resolved
src/modules/rover_ackermann/RoverAckermannGuidance/RoverAckermannGuidance.cpp
Outdated
Show resolved
Hide resolved
src/modules/rover_ackermann/RoverAckermannGuidance/RoverAckermannGuidance.cpp
Outdated
Show resolved
Hide resolved
chfriedrich98
approved these changes
Jul 25, 2024
Ali-barari
pushed a commit
to Ali-barari/AvesAID
that referenced
this pull request
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
The rover wasn't stopping at waypoint if there was a delay on it, and instead was looping around
Solution
Test coverage
Context
Mission :
Before :
2024-07-24.12-26-06.mp4
After :
2024-07-24.12-15-59.mp4