Iridium: upgrade modem and high latency link handling #21172
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: RomanBapst <[email protected]>
- topic update was checked twice in the same loop and thus the second time the topic would never indicate to have updated Co-authored-by: RomanBapst <[email protected]>
Co-authored-by: RomanBapst <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was sometime in the backlog so I am bringing this up so we can decide what to do with it.
I can rebase my PR if this #20817 can get in first or vice versa.
This PR brings two major updates for Iridium and removes messages that will spend SAT credit unnecessarily.
Modem handling
This change how modem presence is detected. It will send an "AT" command to the modem and if the modem responds with "OK" it means the modem is present. Previously it will use messages from satellites to detect if the modem is present or not. This could cause messages to accumulate in the buffer and then send them all at once.
This will result in spending the credit on outdated information.
High latency link handling
High-latency link is now handled differently. It will disable itself if the modem disconnection is detected.
It will work as a backup for standard GCS-link.
Removing standard GCS link, high latency link kicks in:
Disconnecting/connecting modem physically + reconnecting GCS
