This repository was archived by the owner on Sep 3, 2025. It is now read-only.
chore(node): Upgrade to node lts #5394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashbreakpoint
force-pushed
the
chore/upgrade-node
branch
from
a2fe083 to
dbecf98
Compare
Upgrading the docker build and nvm to node 20.18, which is the latest supported, stable LTS version. Node 12 and 16 have been EoL since April, 2022 and August, 2023, respectively. In addition, a transitive dependency of mjml, minimatch, is not compatible with anything less than node 14 at this point, so email generation from templates was broken. With the move to newer node, I had to deal with a new node/docker restriction which won't allow you to `npm install` in the root directory. I wanted to maintain backwards compatiblity with current installs and their MJML_PATH parameter, so I worked around the problem by installing mjml in another directory and then moving node_modules to the root directory. It's not pretty, but it worked. I'm trying to run tests locally and I get one failure, but I'm not sure if it's my setup or something I need to correct. I've manually tested the setup, gone into every page, and not experienced problems.
bashbreakpoint
force-pushed
the
chore/upgrade-node
branch
from
dbecf98 to
05e32f5
Compare
mvilanova
approved these changes
Oct 25, 2024
Contributor
mvilanova
left a comment
mvilanova
left a comment
There was a problem hiding this comment.
Thanks again for giving this file some love!
Contributor
Author
|
Happy to. I'm just working on getting it stood up for PoC and selling it to our business as a solution we need, and I'm just discovering minor things. It's pretty close to how I think it should be, though, so until I have time to work on a couple plugins, I might not have a lot of PRs left here. |
mvilanova
added
enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading the docker build and nvm to node 20.18, which is the latest supported, stable LTS version. Node 12 and 16 have been EoL since April, 2022 and August, 2023, respectively. In addition, a transitive dependency of mjml, minimatch, is not compatible with anything less than node 14 at this point, so email generation from templates was broken. With the move to newer node, I had to deal with a new node/docker restriction which won't allow you to
npm installin the root directory. I wanted to maintain backwards compatiblity with current installs and their MJML_PATH parameter, so I worked around the problem by installing mjml in another directory and then moving node_modules to the root directory. It's not pretty, but it worked. I'm trying to run tests locally and I get one failure, but I'm not sure if it's my setup or something I need to correct. I've manually tested the setup, gone into every page, and not experienced problems.