This repository was archived by the owner on Sep 3, 2025. It is now read-only.
Commit a2fe083
committed
chore(node): Upgrade to node lts
Upgrading the docker build and nvm to node 20.18, which is the latest
supported, stable LTS version. Node 12 and 16 have been EoL since April,
2022 and August, 2023, respectively. In addition, a transitive
dependency of mjml, minimatch, is not compatible with anything less than
node 14 at this point, so email generation from templates was broken.
With the move to newer node, I had to deal with a new node/docker
restriction which won't allow you to `npm install` in the root
directory. I wanted to maintain backwards compatiblity with current
installs and their MJML_PATH parameter, so I worked around the problem
by installing mjml in another directory and then moving node_modules to
the root directory. It's not pretty, but it worked. I'm trying to run
tests locally and I get one failure, but I'm not sure if it's my setup
or something I need to correct. I've manually tested the setup, gone
into every page, and not experienced problems.1 parent 0997901 commit a2fe083
2 files changed
+17
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
90 | | - | |
| 90 | + | |
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
| |||
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
107 | | - | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
108 | 122 | | |
109 | 123 | | |
110 | 124 | | |
| |||
0 commit comments