This repository was archived by the owner on Sep 3, 2025. It is now read-only.
bug(docker): Revert python version bump #5379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The move to python 3.14 breaks the docker build. The srsly package doesn't have a compatible wheel with anything above 3.12 right now, and it's using deprecated methods, so it can't be built by 3.14 yet. Because of this, `docker build .` is broken on master.
mvilanova
approved these changes
Oct 22, 2024
Contributor
Author
|
I'm sorry, I have no idea how to add a label. I suspect I lack permissions to do so (which is fine). |
Contributor
No worries. I'll check if we can give perms to collaborators. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The move to python 3.14 breaks the docker build. The srsly package doesn't have a compatible wheel with anything above 3.12 right now (docs), and it's using deprecated methods, so it can't be built by 3.14 yet. Because of this,
docker build .is broken on master.