Miscategorises URLs as comments

[JamesHenry]

Port of eslint/typescript-eslint-parser#339

[vjeux]

This is still an issue FYI

[armano2]

@vjeux issue is related to JSX support, in "preserve" typescript is not supporting comments, only in "react".

https://github.com/JamesHenry/typescript-estree/blob/master/src/parser.ts#L153

[armano2]

if you use project configuration it will load this information from tsconfig.json

[vjeux]

I'm not sure I understand.

<b>//</b>

currently reports </b> to be a comment, in addition to have the correct JSX AST.

This sounds like a bug and not an issue with configuration.

[armano2]

its not a bug,
http://www.typescriptlang.org/play/#src=const%20foo%20%3D%20%3Cb%3E%2F%2F%3C%2Fb%3E

[vjeux]

The TypeScript playground doesn't support TSX: http://www.typescriptlang.org/play/#src=const%20foo%20%3D%20%3Cb%3E%2F%2F%3C%2Fb%3E

[armano2]

typescripts supports 3 mode of JSX: https://www.typescriptlang.org/docs/handbook/jsx.html#basic-usage and // is allowed only in react

[armano2]

let me double check that...

[Jessidhia]

Sounds like a bug to me; it should work regardless of mode in .tsx files

[armano2]

@vjeux what version of typescript are you using?

[vjeux]

    "typescript": "3.2.1",
    "typescript-estree": "6.0.0-rc.1",

https://github.com/prettier/prettier/blob/master/package.json#L68-L69

Let me know if there's something more recent, I'd be happy to try

[armano2]

i just checked on master and its working fine....

{
  "body": [
    {
      "declarations": [
        {
          "id": {
            "name": "foo",
            "type": "Identifier"
          },
          "init": {
            "children": [
              {
                "raw": "http://example.com",
                "type": "JSXText",
                "value": "http://example.com"
              }
            ],
            "closingElement": {
              "name": {
                "name": "a",
                "type": "JSXIdentifier"
              },
              "type": "JSXClosingElement"
            },
            "openingElement": {
              "attributes": [
                {
                  "name": {
                    "name": "href",
                    "type": "JSXIdentifier"
                  },
                  "type": "JSXAttribute",
                  "value": {
                    "raw": "\"http://example.com\"",
                    "type": "Literal",
                    "value": "http://example.com"
                  }
                }
              ],
              "name": {
                "name": "a",
                "type": "JSXIdentifier"
              },
              "selfClosing": false,
              "type": "JSXOpeningElement"
            },
            "type": "JSXElement"
          },
          "type": "VariableDeclarator"
        }
      ],
      "kind": "const",
      "type": "VariableDeclaration"
    }
  ],
  "sourceType": "script",
  "type": "Program"
}