Miscategorises URLs as comments

[azz]

What version of TypeScript are you using?

2.4

What version of typescript-eslint-parser are you using?

ts-2.4 branch

What code were you trying to parse?

const link = <a href="example.com">http://example.com</a>

What did you expect to happen?

//example.com</a> is not a comment

What happened?

  "comments": [
    {
      "type": "Line",
      "value": "example.com</a>",
      "range": [
        40,
        57
      ],
      "loc": {
        "start": {
          "line": 1,
          "column": 40
        },
        "end": {
          "line": 1,
          "column": 57
        }
      }
    }

[soda0289]

I think we will need to change how comments are processed inside JSX. We should only accept multiline comments inside JSX literal {/* Valid comment */}

[azz]

Looks like this one is still causing some issues.

[kaicataldo]

Single line comments aren't allowed in JSX, so this is definitely an issue. For more context, see eslint/eslint#7030 (comment).

[kaicataldo]

This error comes from here: https://github.com/eslint/typescript-eslint-parser/blob/master/lib/convert-comments.js#L113

[kaicataldo]

I actually wonder if this is a bug in the TypeScript Scanner? Seems like it only returns this token when it's in JSXText nodes.

[JamesHenry]

Ported here JamesHenry/typescript-estree#6