Skip to content

fix: load correct prod version of hermes & use any cmake version #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kewde merged 3 commits into from
Apr 7, 2025
Merged

fix: load correct prod version of hermes & use any cmake version #24

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf5b1fd
fix: load correct prod version of hermes
kewde Apr 4, 2025
98473f8
fix: drop CMake version requirements
kewde Apr 4, 2025
28004f9
fix: go up one more level in search for exodus hermes engine
kewde Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/react-native-reanimated/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,10 @@ android {
}
externalNativeBuild {
cmake {
version = System.getenv("CMAKE_VERSION") ?: "3.22.1"
// We'll let the build system to resolve the version of CMake
// but keeping this here as a reminder that you should actually
// match the version being used in the React Native repo
// version = System.getenv("CMAKE_VERSION") ?: "3.22.1"
path "CMakeLists.txt"
}
}
Expand Down Expand Up @@ -518,7 +521,12 @@ dependencies {

implementation "com.facebook.react:react-android" // version substituted by RNGP
if (JS_RUNTIME == "hermes") {
implementation "com.facebook.react:hermes-android" // version substituted by RNGP
if (System.getenv("BUILD_TYPE") == "release") {
def hermesPath = "../../../@exodus/hermes-engine/android/";
releaseImplementation files(hermesPath + "hermes-release.aar")
} else {
implementation("com.facebook.react:hermes-android")
}
}
}

Expand Down