Skip to content

fix: load correct prod version of hermes & use any cmake version #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kewde merged 3 commits into from
Apr 7, 2025
Merged

fix: load correct prod version of hermes & use any cmake version #24

kewde merged 3 commits into from
Apr 7, 2025

Conversation

@kewde
Copy link

@kewde kewde commented Apr 4, 2025

Summary

  1. We should load the custom hermes build for inclusion during prod builds.
  2. Let's drop the cmake version requirements for now, seems like nobody is building with 3.22.1 in our org, seems a bit of everything lol, let's roll the dice with that one.

@kewde kewde changed the title fix: load correct prod version of hermes fix: load correct prod version of hermes & use any cmake version Apr 4, 2025
alexandrius
alexandrius approved these changes Apr 7, 2025
View reviewed changes
Copy link

@alexandrius alexandrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@kewde kewde merged commit ec7fc50 into exodus-3.16.7 Apr 7, 2025
5 checks passed
@kewde kewde deleted the kewde/fix-load-correct-hermes-impl branch April 7, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexandrius alexandrius alexandrius approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kewde @alexandrius