Skip to content

Conversation

@askoriy
Copy link
Contributor

@askoriy askoriy commented Oct 28, 2022

What's new

  • There is an ability to view the files content directly on the Flipper. It could be useful to review BadUsb scripts before run, read README and notes for collection of downloaded artifacts, view all data from saved NFC, etc.

Verification

  • Now all files in Browser have additional context menu item Show right after Info.

Limitations

  • With current implementation all file content is loaded into memory. Maximum file size is limited by 20K to not crash the Flipper.

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@askoriy askoriy requested a review from xMasterX as a code owner October 28, 2022 03:20
@RogueMaster
Copy link
Contributor

Do you have it limited to certain file types? (.txt, .md for example...)

Any option to add text?

Not sure what Nano thinks, but, I feel like your archive scene show should be it's own app that can view/edit text in files and you can direct the "Show" option to that FAP with the method used on this PR RogueMaster/flipperzero-firmware-wPlugins#382

@RogueMaster
Copy link
Contributor

You could also check the file size and not open the file if it is too big to open...

@xMasterX
Copy link
Member

Do you have it limited to certain file types? (.txt, .md for example...)

Any option to add text?

Not sure what Nano thinks, but, I feel like your archive scene show should be it's own app that can view/edit text in files and you can direct the "Show" option to that FAP with the method used on this PR RogueMaster#382

I modified it with added checks for file types and with some fixes
Also no need to make it external .fap since change itself is not that big

Copy link
Member

@xMasterX xMasterX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR, after my little changes seems pretty stable

@xMasterX xMasterX merged commit b287cb4 into DarkFlippers:dev Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants