This repository was archived by the owner on Mar 12, 2025. It is now read-only.
PHP Syntax Fixes #30
Merged
PHP Syntax Fixes #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naktibalda
suggested changes
May 13, 2018
There was a problem hiding this comment.
Please rebase this branch on 7.0, because your pull request is in conflict after merging #28
fishfacemcgee
force-pushed
the
static-fixes
branch
from
af6fe89 to
fdf2391
Compare
|
@Naktibalda Updated. Thanks for taking a look so quickly. |
|
Thanks |
DavertMik
approved these changes
May 14, 2018
|
@Naktibalda @DavertMik Sorry to bother, but is there a rough ETA on when this PR could get merged and a new release pushed out? Assuming, of course, there aren't any lingering issues with the PR. Thanks in advance! |
|
I tagged 7.1.2 release with all these changes. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running across #28, I did some more digging and hit a few more instances of missing
stringreturn types for toString overrides. I installed phpstan to see if I could catch anything else, and that's how I found thegetFilteredStackTracecall. However, most of the issues phpstan is reporting are due to this repo referencing code from Codeception/Codeception, so I opted to not include phpstan in this PR.