Skip to content
This repository was archived by the owner on Mar 12, 2025. It is now read-only.

Fix return type #28

Merged
merged 1 commit into from
May 13, 2018
Merged

Fix return type #28

merged 1 commit into from
May 13, 2018

Conversation

enumag
Copy link
Member

@enumag enumag commented May 4, 2018 

PHP Fatal error:  Declaration of Codeception\PHPUnit\Constraint\Page::toString() must be compatible with PHPUnit\Framework\SelfDescribing::toString(): string in vendor/codeception/phpunit-wrapper/src/Constraint/Page.php on line 79

Naktibalda
Naktibalda approved these changes May 4, 2018
View reviewed changes
Copy link
Member

@Naktibalda Naktibalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method signatures are updated one by one.
I am sure that there is a tool that could find all signature mismatches in one go.

@KacerCZ
Copy link

KacerCZ commented May 10, 2018

Phpstan (https://github.com/phpstan/phpstan) is tool for this job.

@enumag
Copy link
Member Author

enumag commented May 13, 2018

Can someone merge this please?

@fishfacemcgee fishfacemcgee mentioned this pull request May 13, 2018
Merged
@Naktibalda Naktibalda merged commit 327b4b7 into Codeception:7.0 May 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Naktibalda Naktibalda Naktibalda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enumag @KacerCZ @Naktibalda