-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[CHIA-3795] change v1 plot phase-out #20216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75f8aa6 to
d1fb255
Compare
d1fb255 to
a6ef930
Compare
arvidn
commented
Nov 2, 2025
almogdepaz
reviewed
Nov 3, 2025
almogdepaz
reviewed
Nov 3, 2025
almogdepaz
reviewed
Nov 3, 2025
almogdepaz
reviewed
Nov 3, 2025
3d769be to
78d1f92
Compare
Contributor
|
almogdepaz
approved these changes
Nov 5, 2025
wjblanke
approved these changes
Nov 6, 2025
Contributor
wjblanke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
ready_to_merge
Submitter and reviewers think this is ready
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to not affect required_iters which will change block infusion distribution in the slot and to be quantized to epoch blocksץ
The phase-out check is implemented in
is_v1_phased_out().The proof-of-space, when validated (as opposed to farmed) uses
verify_and_get_quality_string(), which now needs to take the previous transaction block height, to check the phase-out.When farming, we need to check the phase-out independently now. There are new calls to
is_v1_phased_out()inharvester_api.pyas well asblock_tools.py.calculate_iterations_quality()no longer needs to take sub slot iterators nor height, since it doesn't implement the phase-out anymore. The phase-out is now separate from computing quality.