Skip to content

Conversation

@arvidn
Copy link
Contributor

@arvidn arvidn commented Nov 2, 2025

to not affect required_iters which will change block infusion distribution in the slot and to be quantized to epoch blocksץ

The phase-out check is implemented in is_v1_phased_out().

The proof-of-space, when validated (as opposed to farmed) uses verify_and_get_quality_string(), which now needs to take the previous transaction block height, to check the phase-out.

When farming, we need to check the phase-out independently now. There are new calls to is_v1_phased_out() in harvester_api.py as well as block_tools.py.

calculate_iterations_quality() no longer needs to take sub slot iterators nor height, since it doesn't implement the phase-out anymore. The phase-out is now separate from computing quality.

@arvidn arvidn requested a review from a team as a code owner November 2, 2025 12:26
@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Nov 2, 2025
@arvidn arvidn force-pushed the plot-v1-phase-out branch 2 times, most recently from 75f8aa6 to d1fb255 Compare November 2, 2025 12:34
@arvidn arvidn force-pushed the plot-v1-phase-out branch from d1fb255 to a6ef930 Compare November 2, 2025 13:10
@arvidn arvidn changed the title change v1 plot phase-out [CHIA-3795] change v1 plot phase-out Nov 3, 2025
@arvidn arvidn force-pushed the plot-v1-phase-out branch from 3d769be to 78d1f92 Compare November 4, 2025 00:18
@arvidn arvidn requested a review from almogdepaz November 4, 2025 00:35
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

File Coverage Missing Lines
chia/full_node/full_node_api.py 71.4% lines 900-901
chia/harvester/harvester_api.py 25.0% lines 301, 304, 308
chia/simulator/block_tools.py 75.0% lines 1594
chia/types/blockchain_format/proof_of_space.py 86.7% lines 124-125
Total Missing Coverage
59 lines 8 lines 86%

Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Nov 6, 2025
@pmaslana pmaslana merged commit ece6de2 into main Nov 6, 2025
614 of 618 checks passed
@pmaslana pmaslana deleted the plot-v1-phase-out branch November 6, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants