formatted composer completion and used helper function #1807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
It'd be great to get someone to manually test this ... also to tell me what composer is. |
Member
Author
|
NoahGorny
force-pushed
the
cleanup/composer-completions
branch
from
4fb522d to
0ebc067
Compare
NoahGorny
force-pushed
the
cleanup/composer-completions
branch
from
0ebc067 to
0d963b2
Compare
cornfeedhobo
reviewed
Feb 5, 2021
| local cur script coms opts com | ||
| COMPREPLY=() | ||
| _get_comp_words_by_ref -n : cur words | ||
| function _composer() { |
Member
There was a problem hiding this comment.
@NoahGorny Could you change this to __composer_complete or __composer_completion?
cornfeedhobo
approved these changes
Feb 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup composer completion as part of #1782