-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Cleaned some completion files and using _command_exists helper function #1782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @tbhaxor, I am impressed by the effort you have put in this PR. I suggest, for the ease of checking this, that you split this PR to one completion file at a time. This will help us review and merge it faster. You already did good by splitting the changes between commits, so it should not be so difficult. |
|
@NoahGorny Since this PR for one specific change that's why I have created one PR. If you still want file / PR, I will do it from next time |
Its just very hard to CR, if you dont want, I can open them up myself |
I would so thankful. BTW, what's CR? |
CR- Code Review, as in reviewing the code and deciding if it's ready or not 😄 |
I have split this PR into many separate pieces, ignoring removal commits or commits that touch code that we copied from somewhere. you are welcome to take a look @tbhaxor Closing this as we will continue in those PRs |
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.