Skip to content

Conversation

@tbhaxor
Copy link
Contributor

@tbhaxor tbhaxor commented Jan 10, 2021

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@NoahGorny
Copy link
Member

Hey @tbhaxor, I am impressed by the effort you have put in this PR. I suggest, for the ease of checking this, that you split this PR to one completion file at a time. This will help us review and merge it faster. You already did good by splitting the changes between commits, so it should not be so difficult.
Thank you for doing this!

@tbhaxor
Copy link
Contributor Author

tbhaxor commented Jan 14, 2021

@NoahGorny Since this PR for one specific change that's why I have created one PR.

If you still want file / PR, I will do it from next time

@NoahGorny
Copy link
Member

@NoahGorny Since this PR for one specific change that's why I have created one PR.

If you still want file / PR, I will do it from next time

Its just very hard to CR, if you dont want, I can open them up myself

@tbhaxor
Copy link
Contributor Author

tbhaxor commented Jan 15, 2021

@NoahGorny Since this PR for one specific change that's why I have created one PR.
If you still want file / PR, I will do it from next time

Its just very hard to CR, if you dont want, I can open them up myself

I would so thankful. BTW, what's CR?

@NoahGorny
Copy link
Member

@NoahGorny Since this PR for one specific change that's why I have created one PR.
If you still want file / PR, I will do it from next time

Its just very hard to CR, if you dont want, I can open them up myself

I would so thankful. BTW, what's CR?

CR- Code Review, as in reviewing the code and deciding if it's ready or not 😄

@NoahGorny
Copy link
Member

@NoahGorny Since this PR for one specific change that's why I have created one PR.

If you still want file / PR, I will do it from next time

I have split this PR into many separate pieces, ignoring removal commits or commits that touch code that we copied from somewhere. you are welcome to take a look @tbhaxor

Closing this as we will continue in those PRs

@NoahGorny NoahGorny closed this Jan 16, 2021
@tbhaxor tbhaxor deleted the cleanup/completions branch January 23, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants