AP_ICEngine: Initialise idle governor at start percent #31727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamPete1
reviewed
Dec 15, 2025
| if (!ap_rpm->get_rpm(rpm_instance-1, rpmv) || rpmv < 1) { | ||
| // Reset idle point to the default value when the engine is stopped | ||
| idle_governor_integrator = min_throttle; | ||
| idle_governor_integrator = start_percent.get(); |
Member
There was a problem hiding this comment.
Would it be better to set idle_point_initialized = false here? Maybe we should do the same for the return on 655?
Contributor
Author
There was a problem hiding this comment.
yeh that's probably a bit clearer
LachlanConn
force-pushed
the
idle_governor__initialise_at_start_pct
branch
from
aad74f5 to
6d5cb7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behaviour has a harsh dip from start percent to minimum throttle before slewing up to defined idle governor RPM.
This change now slews smoothly from whatever the start percent is, up or down to the defined idle governor RPM.