AP_Scripting: fix CRSF leaks and nullptr dereferences #31718
+31
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyp1per
requested changes
Dec 15, 2025
Contributor
andyp1per
left a comment
andyp1per
left a comment
There was a problem hiding this comment.
Need to see the changes without the metatable stuff. Will certainly require testing
Contributor
Author
|
Please review the last two commits, they are well isolated from the metatable changes. Will rebase then undraft before merging. |
There are several bogus error messages and checks that are removed. This should probably be refactored to use ap_objects and avoid reallocation of the underlying bits.
tpwrules
force-pushed
the
pr/scripting-crsf-nullptr
branch
from
409f645 to
e4db985
Compare
andyp1per
reviewed
Dec 16, 2025
Contributor
andyp1per
left a comment
andyp1per
left a comment
There was a problem hiding this comment.
LGTM but will need testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several bogus error messages and checks that are removed.
This should probably be refactored to use ap_objects and avoid reallocation of the underlying bits.
On top of #31717 for logistical reasons. Not tested, just compiled.