-
Notifications
You must be signed in to change notification settings - Fork 66
Allow publishing to pypi when tags are pushed #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
17e5f55
e7354d3
f291af7
2c1f4cf
efaa311
823c3e6
1e40ff1
b304690
a1b6a9e
b78ff88
bebaa79
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,95 @@ | ||
name: publish kyber-py to pypi | ||
|
||
on: push | ||
|
||
jobs: | ||
build: | ||
name: Build distribution | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
with: | ||
persist-credentials: false | ||
- name: Set up Python | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version: "3.x" | ||
- name: Install pypa/build | ||
run: >- | ||
python3 -m | ||
pip install | ||
build | ||
--user | ||
- name: Build a binary wheel and a source tarball | ||
run: python3 -m build | ||
- name: Store the distribution packages | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: python-package-distributions | ||
path: dist/ | ||
|
||
publish-to-pypi: | ||
name: >- | ||
Publish Python distribution to PyPI | ||
if: startsWith(github.ref, 'refs/tags/') # only publish to PyPI on tag pushes | ||
needs: | ||
- build | ||
runs-on: ubuntu-latest | ||
environment: | ||
name: pypi | ||
url: https://pypi.org/p/kyber-py | ||
GiacomoPope marked this conversation as resolved.
Show resolved
Hide resolved
|
||
permissions: | ||
id-token: write # IMPORTANT: mandatory for trusted publishing | ||
|
||
steps: | ||
- name: Download all the dists | ||
uses: actions/download-artifact@v4 | ||
with: | ||
name: python-package-distributions | ||
path: dist/ | ||
- name: Publish distribution to PyPI | ||
uses: pypa/gh-action-pypi-publish@release/v1 | ||
|
||
github-release: | ||
name: >- | ||
Sign the Python distribution with Sigstore | ||
and upload them to GitHub Release | ||
needs: | ||
- publish-to-pypi | ||
runs-on: ubuntu-latest | ||
|
||
permissions: | ||
contents: write # IMPORTANT: mandatory for making GitHub Releases | ||
id-token: write # IMPORTANT: mandatory for sigstore | ||
|
||
steps: | ||
- name: Download all the dists | ||
uses: actions/download-artifact@v4 | ||
with: | ||
name: python-package-distributions | ||
path: dist/ | ||
- name: Sign the dists with Sigstore | ||
uses: sigstore/[email protected] | ||
with: | ||
inputs: >- | ||
./dist/*.tar.gz | ||
./dist/*.whl | ||
- name: Create GitHub Release | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.PYPI_API_TOKEN }} | ||
GiacomoPope marked this conversation as resolved.
Show resolved
Hide resolved
GiacomoPope marked this conversation as resolved.
Show resolved
Hide resolved
|
||
run: >- | ||
gh release create | ||
"$GITHUB_REF_NAME" | ||
--repo "$GITHUB_REPOSITORY" | ||
--notes "" | ||
- name: Upload artifact signatures to GitHub Release | ||
GiacomoPope marked this conversation as resolved.
Show resolved
Hide resolved
|
||
env: | ||
GITHUB_TOKEN: ${{ secrets.PYPI_API_TOKEN }} | ||
GiacomoPope marked this conversation as resolved.
Show resolved
Hide resolved
|
||
# Upload to GitHub Release using the `gh` CLI. | ||
# `dist/` contains the built packages, and the | ||
# sigstore-produced signatures and certificates. | ||
run: >- | ||
gh release upload | ||
"$GITHUB_REF_NAME" dist/** | ||
--repo "$GITHUB_REPOSITORY" |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,3 +1,25 @@ | ||||||
[build-system] | ||||||
requires = ["hatchling"] | ||||||
build-backend = "hatchling.build" | ||||||
|
||||||
[project] | ||||||
name = "kyber-py" | ||||||
version = "0.1.0" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. shouldn't this be "1.0.0" ? we have https://github.com/GiacomoPope/kyber-py/releases/tag/v1.0 ... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah I agree There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perhaps, something newer since the repo advanced since?
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what's the meaning of the dev0 part? I would be ok with 1.0.1 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's so that if somebody installs the package from a git checkout, and then updates packages with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Some projects advance Git to |
||||||
requires-python = ">=3.9" | ||||||
GiacomoPope marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
description = "A pure python implementation of ML-KEM (FIPS 203)" | ||||||
readme = "README.md" | ||||||
classifiers = [ | ||||||
"Topic :: Security :: Cryptography", | ||||||
"Programming Language :: Python :: 3", | ||||||
"License :: OSI Approved :: MIT License", | ||||||
GiacomoPope marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
] | ||||||
license = "MIT" | ||||||
license-files = ["LICEN[CS]E*"] | ||||||
GiacomoPope marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
|
||||||
[project.urls] | ||||||
Homepage = "https://github.com/GiacomoPope/kyber-py" | ||||||
Issues = "https://github.com/GiacomoPope/kyber-py/issues" | ||||||
|
||||||
[tool.black] | ||||||
line-length = 79 | ||||||
|
||||||
|
Uh oh!
There was an error while loading. Please reload this page.