-
Notifications
You must be signed in to change notification settings - Fork 66
Allow publishing to pypi when tags are pushed #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not familiar with the github actions workflows to publish to pypi so can't say one way or the other if it's correct; "passes sniff test" is the best I can do 🙂
pyproject.toml
Outdated
|
||
[project] | ||
name = "kyber-py" | ||
version = "0.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be "1.0.0" ?
we have https://github.com/GiacomoPope/kyber-py/releases/tag/v1.0 ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps, something newer since the repo advanced since?
version = "0.1.0" | |
version = "1.0.1.dev0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the meaning of the dev0 part? I would be ok with 1.0.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's so that if somebody installs the package from a git checkout, and then updates packages with pip
, they get the actual released 1.0.1 version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, 1.0.1.dev0 < 1.0.1
during dependency resolution. It's one of the possible pre-releases. See PEP 440 for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some projects advance Git to .dev0
right after cutting a release and then bump to a stable version before making the next one.
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One blocker + a thing to consider.
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Thanks for the additional suggestions, I must have misclicked when committing your suggestions. If you agree now, I will push the tag |
Sounds good. Don't forget to commit the version bump before doing the second tag. |
@webknjaz thanks for all your help! Looks like it worked! |
So the goal of this PR is to get the project ready so that new tags push the project to pypi too.
Maybe I need to do more for this to work, and the CI seems to be failing for something adjacent?
Edit: failure is because https://coveralls.io is down right now.