Skip to content

Conversation

GiacomoPope
Copy link
Owner

@GiacomoPope GiacomoPope commented Feb 13, 2025

So the goal of this PR is to get the project ready so that new tags push the project to pypi too.

Maybe I need to do more for this to work, and the CI seems to be failing for something adjacent?

Edit: failure is because https://coveralls.io is down right now.

@GiacomoPope GiacomoPope marked this pull request as ready for review February 13, 2025 14:35
@GiacomoPope GiacomoPope changed the title Create release-pypi.yml Allow publishing to pypi when tags are pushed Feb 13, 2025
@GiacomoPope GiacomoPope requested a review from tomato42 February 13, 2025 14:40
@webknjaz webknjaz mentioned this pull request Feb 26, 2025
Copy link
Collaborator

@tomato42 tomato42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not familiar with the github actions workflows to publish to pypi so can't say one way or the other if it's correct; "passes sniff test" is the best I can do 🙂

pyproject.toml Outdated

[project]
name = "kyber-py"
version = "0.1.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I agree

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, something newer since the repo advanced since?

Suggested change
version = "0.1.0"
version = "1.0.1.dev0"

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the meaning of the dev0 part? I would be ok with 1.0.1

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's so that if somebody installs the package from a git checkout, and then updates packages with pip, they get the actual released 1.0.1 version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, 1.0.1.dev0 < 1.0.1 during dependency resolution. It's one of the possible pre-releases. See PEP 440 for more details.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some projects advance Git to .dev0 right after cutting a release and then bump to a stable version before making the next one.

GiacomoPope and others added 2 commits February 27, 2025 10:43
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
GiacomoPope and others added 4 commits March 3, 2025 18:00
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Copy link
Contributor

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One blocker + a thing to consider.

Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
@GiacomoPope
Copy link
Owner Author

Thanks for the additional suggestions, I must have misclicked when committing your suggestions. If you agree now, I will push the tag 1.0.1.dev0 and if this passes and uploads to pypi then I will do a second tag for 1.0.1

@GiacomoPope GiacomoPope merged commit 2dfabe9 into main Mar 4, 2025
17 checks passed
@webknjaz
Copy link
Contributor

webknjaz commented Mar 4, 2025

Sounds good. Don't forget to commit the version bump before doing the second tag.

@GiacomoPope
Copy link
Owner Author

@webknjaz thanks for all your help! Looks like it worked!

https://pypi.org/project/kyber-py/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants