-
Notifications
You must be signed in to change notification settings - Fork 12
Fix parse Error in case sync #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parse Error in case sync #105
Conversation
|
Thanks for the PR, though I do want to look into the error you received a little more before merging this. I'm not seeing this error in any versions of ZSH I've tried. The syntax before this change is perfectly valid and should not have raised a parse error, which leads me to believe something else is going on. Would you mind posting a copy of your Note to self: I really must enable OSX builds on Travis again |
|
No problem. |
|
Absolutely, my email is [email protected] :) |
|
voilà :) |
|
Got it, thanks. I'll take a look at this at some point tomorrow |
|
No emergency :) |
|
I never managed to get to the bottom of this - spent a while looking at your Before I do that, @AdrieanKhisbe could you please rebase your branch on the |
5c2ef47 to
aadea31
Compare
|
Strange Strange. Thanks a lot for the time invested ! I just rebased as you requested :) |
|
Have you a target in mind for 1.5.0? |
|
Yeah, the |
|
Oh, I can change the base myself. Awesome. LGTM. Thanks for the PR @AdrieanKhisbe |
|
I don't know why I thought I couldn't ^^ |
protect case option with () to prevent parse error
should fix #104