merge upstream

.custom-gcl.yml

@@ -1,6 +1,6 @@
 # yaml-language-server: $schema=https://golangci-lint.run/jsonschema/custom-gcl.jsonschema.json
 
-version: v2.0.2
+version: v2.3.0
 
 destination: ./_tools
 

.dprint.jsonc

@@ -59,7 +59,7 @@
     // Note: if adding new languages, make sure settings.template.json is updated too.
     // Also, if updating typescript, update the one in package.json.
     "plugins": [
-        "https://plugins.dprint.dev/typescript-0.95.7.wasm",
+        "https://plugins.dprint.dev/typescript-0.95.8.wasm",
         "https://plugins.dprint.dev/json-0.20.0.wasm",
         "https://plugins.dprint.dev/g-plane/pretty_yaml-v0.5.1.wasm",
         "https://plugins.dprint.dev/exec-0.5.1.json@492414e39dea4dccc07b4af796d2f4efdb89e84bae2bd4e1e924c0cc050855bf"

.github/ISSUE_TEMPLATE/01-crash.md

@@ -0,0 +1,18 @@
+---
+name: Crash
+about: Using tsgo or the language server caused a panic
+title: ''
+labels: Crash
+assignees: ''
+
+---
+
+## Stack trace
+
+```
+[paste stack trace here]
+```
+
+## Steps to reproduce
+
+1.

.github/ISSUE_TEMPLATE/02-behavior-difference.md

@@ -0,0 +1,16 @@
+---
+name: Behavior Difference
+about: tsgo produces different results than TypeScript 5.8
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+## Steps to reproduce
+
+<!-- Share a repository link or a code sample -->
+
+## Behavior with `[email protected]`
+
+## Behavior with `tsgo`

.github/ISSUE_TEMPLATE/03-other.md

@@ -0,0 +1,10 @@
+---
+name: Other
+about: Something else
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+

.github/ISSUE_TEMPLATE/04-copilot-pr-porting.md

@@ -0,0 +1,26 @@
+---
+name: '[TypeScript Team Use] Copilot PR porting'
+about: Instructions for Copilot to port a PR from microsoft/TypeScript
+title: 'Port TypeScript PR #[NNNNN]'
+labels: Porting PR
+assignees: ''
+
+---
+
+This repository is a port of microsoft/TypeScript from TypeScript to Go. Since the port began, the following pull request was applied to microsoft/TypeScript. An equivalent change now needs to be applied here.
+
+## PR to port
+
+- PR link: <!-- https://github.com/microsoft/TypeScript/pull/NNNNN -->
+- Squash commit diff: <!-- Copy the squash commit link and append ".patch", e.g. https://github.com/microsoft/TypeScript/commit/a271797c1a95494e5f7aa8075c01941ad25cad08.patch -->
+
+## Instructions
+
+1. Use `playwright` to view the PR listed above
+2. Apply the edits made in that PR to this codebase, translating them from TypeScript to Go.
+   - The change may or may not be applicable. It may have already been ported. Do not make any significant changes outside the scope of the diff. If the change cannot be applied without significant out-of-scope changes, explain why and stop working.
+   - Tip: search for functions and identifiers from the diff to find the right location to apply edits. Some files in microsoft/TypeScript have been split into multiple.
+   - Tip: some changes have already been ported, like changes to diagnostic message text. Tests do not need to be ported as they are imported from the submodule.
+3. Refer to your copilot_instructions.md for guidance on how to build and test your change. Note the following differences to the typical development workflow:
+   - Since you are porting the implementation for a behavior that already has tests in the submodule, you don't need to add new tests. Instead, your change should change existing baselines.
+   - If done correctly, you should see removals in `.diff` baselines. These `.diff` removals are your ultimate source of truth: your change is not correct unless diffs are reduced.

.github/actions/setup-go/action.yml

@@ -5,12 +5,16 @@ inputs:
   go-version:
     description: Go version range to set up.
     default: '>=1.24.0'
-  cache-name:
-    description: Name of scoped cache for this set up.
-    default: 'cache'
+  create:
+    description: Create the cache
+    default: 'false'
+  lint-cache:
+    description: Restore the golangci-lint cache
+    default: 'false'
 
 runs:
   using: composite
+
   steps:
     - name: Install Go
       id: install-go
@@ -19,17 +23,107 @@ runs:
         go-version: ${{ inputs.go-version }}
         cache: false
 
-    - name: Go cache
-      uses: actions/cache@5a3ec84eff668545956fd18022155c47e93e2684 # v4.2.3
+    # Avoid hardcoding the cache keys more than once.
+    - name: Get cache info
+      shell: bash
+      id: cache-info
+      env:
+        MODULES_KEY: go-modules-${{ runner.os }}-${{ steps.install-go.outputs.go-version }}-${{ hashFiles('**/go.sum', '**/.custom-gcl.yml') }}
+        LINT_KEY: golangci-lint-${{ runner.os }}-${{ steps.install-go.outputs.go-version }}-${{ hashFiles('**/go.sum', '**/.custom-gcl.yml') }}
+        BUILD_KEY: go-build-cache-${{ runner.os }}-${{ steps.install-go.outputs.go-version }}
+      run: |
+        echo "modules-key=$MODULES_KEY" >> $GITHUB_OUTPUT
+        echo "lint-key=$LINT_KEY" >> $GITHUB_OUTPUT
+        echo "build-key=$BUILD_KEY" >> $GITHUB_OUTPUT
+        echo "GOLANGCI_LINT_CACHE=$RUNNER_TEMP/golangci-lint-cache" >> $GITHUB_ENV
+
+    - if: ${{ inputs.create != 'true' }}
+      name: Restore Go modules
+      uses: actions/cache/restore@5a3ec84eff668545956fd18022155c47e93e2684 # v4.2.3
+      with:
+        key: ${{ steps.cache-info.outputs.modules-key }}
+        path: |
+          ~/go/pkg/mod
+
+    - if: ${{ inputs.create != 'true' }}
+      name: Restore Go build cache
+      uses: actions/cache/restore@5a3ec84eff668545956fd18022155c47e93e2684 # v4.2.3
+      with:
+        key: unused-key-${{ github.run_id }}
+        restore-keys: ${{ steps.cache-info.outputs.build-key }}-
+        path: |
+          ~/.cache/go-build
+          ~/Library/Caches/go-build
+          ~/AppData/Local/go-build
+
+    - if: ${{ inputs.create != 'true' && inputs.lint-cache == 'true' }}
+      name: Restore golangci-lint cache
+      uses: actions/cache/restore@5a3ec84eff668545956fd18022155c47e93e2684 # v4.2.3
+      with:
+        key: unused-key-${{ github.run_id }}
+        restore-keys: ${{ steps.cache-info.outputs.lint-key }}-
+        path: ${{ env.GOLANGCI_LINT_CACHE }}
+
+    - name: Set mtimes
+      shell: bash
+      run: |
+        find . -type f ! -path ./.git/\*\* | go run github.com/slsyy/mtimehash/cmd/[email protected] || true
+        find . -type d ! -path ./.git/\*\* -exec touch -d '1970-01-01T00:00:01Z' {} + || true
+
+    # All steps below are only run if the cache is being created.
+
+    - if: ${{ inputs.create == 'true' }}
+      shell: bash
+      run: npm ci
+
+    - if: ${{ inputs.create == 'true' }}
+      shell: bash
+      run: |
+        go mod download
+        cd _tools
+        go mod download
+
+    - if: ${{ inputs.create == 'true' }}
+      shell: bash
+      run: npx hereby build
+
+    - if: ${{ inputs.create == 'true' }}
+      shell: bash
+      run: npx hereby test
+
+    - if: ${{ inputs.create == 'true' }}
+      shell: bash
+      run: npx hereby lint
+
+    - if: ${{ inputs.create == 'true' }}
+      shell: bash
+      run: npx hereby lint --noembed
+
+    - if: ${{ inputs.create == 'true' }}
+      shell: bash
+      run: npx dprint check
+
+    - if: ${{ inputs.create == 'true' }}
+      name: Save Go modules
+      uses: actions/cache/save@5a3ec84eff668545956fd18022155c47e93e2684 # v4.2.3
       with:
-        # There is more code downloaded and built than is covered by '**/go.sum',
-        # so give each job its own cache to try and not end up sharing the wrong
-        # cache between jobs.
-        key: ts-setup-go-${{ runner.os }}-${{ steps.install-go.outputs.go-version }}-${{ hashFiles('**/go.sum', '**/Herebyfile.mjs', '**/.custom-gcl.yml') }}-${{ github.workflow }}-${{ inputs.cache-name }}
-        restore-keys: |
-          ts-setup-go-${{ runner.os }}-${{ steps.install-go.outputs.go-version }}-${{ hashFiles('**/go.sum', '**/Herebyfile.mjs', '**/.custom-gcl.yml') }}
+        key: ${{ steps.cache-info.outputs.modules-key }}
         path: |
           ~/go/pkg/mod
+
+    - if: ${{ inputs.create == 'true' }}
+      name: Save Go build cache
+      uses: actions/cache/save@5a3ec84eff668545956fd18022155c47e93e2684 # v4.2.3
+      with:
+        key: ${{ steps.cache-info.outputs.build-key }}-${{ github.run_id }}
+        path: |
           ~/.cache/go-build
           ~/Library/Caches/go-build
           ~/AppData/Local/go-build
+
+    - if: ${{ inputs.create == 'true' }}
+      name: Save golangci-lint cache
+      uses: actions/cache/save@5a3ec84eff668545956fd18022155c47e93e2684 # v4.2.3
+      with:
+        key: ${{ steps.cache-info.outputs.lint-key }}-${{ github.run_id }}
+        path: ${{ env.GOLANGCI_LINT_CACHE }}

.github/codeql/codeql-configuration.yml

@@ -9,3 +9,6 @@ query-filters:
   # This query takes too long on complicated string manipulations
   - exclude:
       id: go/unsafe-quoting
+  # Times out in our code.
+  - exclude:
+      id: go/allocation-size-overflow

.github/copilot-instructions.md

@@ -9,23 +9,29 @@ Most of our development takes place in the `internal` directory, and most behavi
 
 Most development on the codebase is in Go.
 Standard Go commands and practices apply, but we primarily use a tool called `hereby` to build, run tests, and other tasks.
-Feel free to install `hereby` globally (`npm install -g hereby`) if it is easier, and run `hereby --list` to see all available commands.
+Run `npx hereby --list` to see all available commands.
 
 ```sh
-hereby build  # Build the project
-hereby test   # Run tests
-hereby format # Format the code
-hereby lint   # Run linters
+npx hereby build  # Build the project
+npx hereby test   # Run tests
+npx hereby format # Format the code
+npx hereby lint   # Run linters
+
+# To run a specific compiler test:
+go test -run='TestSubmodule/<test name>' ./internal/testrunner  # For submodule tests in _submodules/TypeScript
+go test -run='TestLocal/<test name>' ./internal/testrunner     # For local tests in testdata/tests/cases
 ```
 
-Always make sure code is formatted, linted, and tested before sending a pull request.
-
+Always make sure code is formatted, linted, and tested before sending a pull request.
+
 ## Compiler Features, Fixes, and Tests
 
 When fixing a bug or implementing a new feature, at least one minimal test case should always be added in advance to verify the fix.
 This project primarily uses snapshot/baseline/golden tests rather than unit tests.
 New compiler tests are written in `.ts`/`.tsx` files in the directory `testdata/tests/cases/compiler/`, and are written in the following format:
 
+**Note:** Issues with editor features cannot be tested with compiler tests in `testdata/tests/cases/`. Editor functionality requires integration testing with the language server.
+
 ```ts
 // @target: esnext
 // @module: preserve
@@ -50,8 +56,10 @@ export interface Person {
 function greet(person) {
     console.log(`Hello, ${person.name}!`);
 }
-```
-
+```
+
+**New compiler tests should always enable strict mode (`@strict: true`) unless the bug specifically involves non-strict mode behavior.**
+
 Tests don't always need the above `@option`s specified, but they are common to specify or modify.
 Tests can be run with multiple settings for a given option by using a comma-separated list (e.g. `@option: settingA,settingB`).
 `@filename` is only required when a test has multiple files, or when writing a test for a single JavaScript file (where `allowJs` or `checkJs` is enabled).
@@ -79,6 +87,12 @@ It is ideal to implement features and fixes in the following order, and commit c
 
 It is fine to implement more and more of a feature across commits, but be sure to update baselines every time so that reviewers can measure progress.
 
+## Code Porting Reference
+
+The code in `internal` is ported from the code in `_submodules/TypeScript`.
+When implementing features or fixing bugs, those files should be searched for similar functions when code is either missing or potentially wrong.
+The TypeScript submodule serves as the reference implementation for behavior and functionality.
+
 # Other Instructions
 
 - Do not add or change existing dependencies unless asked to.

.github/workflows/ci.yml

@@ -28,8 +28,6 @@ jobs:
       - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
       - uses: dtolnay/rust-toolchain@fcf085fcb4b4b8f63f96906cd713eb52181b5ea4 # stable
       - uses: ./.github/actions/setup-go
-        with:
-          cache-name: build
 
       # Avoid duplicate PR annotations.
       - name: Disable PR annotations
@@ -112,8 +110,6 @@ jobs:
           node-version: 'lts/*'
       - uses: dtolnay/rust-toolchain@fcf085fcb4b4b8f63f96906cd713eb52181b5ea4 # stable
       - uses: ./.github/actions/setup-go
-        with:
-          cache-name: test
 
       # Avoid duplicate PR annotations.
       - if: ${{ ! matrix.config.main }}
@@ -200,7 +196,7 @@ jobs:
       - uses: dtolnay/rust-toolchain@fcf085fcb4b4b8f63f96906cd713eb52181b5ea4 # stable
       - uses: ./.github/actions/setup-go
         with:
-          cache-name: lint${{ (matrix.config.noembed && '-noembed') || ''}}
+          lint-cache: 'true'
 
       # Avoid duplicate PR annotations.
       - if: ${{ ! matrix.config.main }}
@@ -222,8 +218,6 @@ jobs:
       - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
       - uses: dtolnay/rust-toolchain@fcf085fcb4b4b8f63f96906cd713eb52181b5ea4 # stable
       - uses: ./.github/actions/setup-go
-        with:
-          cache-name: format
 
       - run: npm ci
 
@@ -240,21 +234,16 @@ jobs:
           node-version: '>=22.16.0'
       - uses: dtolnay/rust-toolchain@fcf085fcb4b4b8f63f96906cd713eb52181b5ea4 # stable
       - uses: ./.github/actions/setup-go
-        with:
-          cache-name: generate
 
       - run: npm ci
 
       - run: npx hereby generate
 
-      - run: node ./internal/lsp/lsproto/_generate/fetchModel.mjs
-      - run: node ./internal/lsp/lsproto/_generate/generate.mjs
-
-      - name: Remove all converted fourslash tests
-        run: rm -rf internal/fourslash/tests/gen
+      - run: node --experimental-strip-types ./internal/lsp/lsproto/_generate/fetchModel.mts
+      - run: node --experimental-strip-types ./internal/lsp/lsproto/_generate/generate.mts
 
-      - name: Regenerate fourslash tests
-        run: npm run convertfourslash
+      - name: Regenerate fourslash tests and update failing test list
+        run: npm run updatefailing
 
       - run: git add .
       - run: git diff --staged --exit-code --stat
@@ -264,8 +253,6 @@ jobs:
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
       - uses: ./.github/actions/setup-go
-        with:
-          cache-name: tidy
 
       - run: go mod tidy -diff
       - run: go -C ./_tools mod tidy -diff
@@ -279,8 +266,6 @@ jobs:
       - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
       - uses: dtolnay/rust-toolchain@fcf085fcb4b4b8f63f96906cd713eb52181b5ea4 # stable
       - uses: ./.github/actions/setup-go
-        with:
-          cache-name: smoke
 
       # Avoid duplicate PR annotations.
       - name: Disable PR annotations
@@ -305,8 +290,6 @@ jobs:
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
       - uses: ./.github/actions/setup-go
-        with:
-          cache-name: misc
 
       - run: go -C ./_tools run ./cmd/checkmodpaths $PWD
 
@@ -319,8 +302,6 @@ jobs:
       - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
       - uses: dtolnay/rust-toolchain@fcf085fcb4b4b8f63f96906cd713eb52181b5ea4 # stable
       - uses: ./.github/actions/setup-go
-        with:
-          cache-name: baselines
 
       - run: npm ci