Skip to content

Conversation

@icemac
Copy link
Member

@icemac icemac commented Nov 28, 2025

No description provided.

@icemac icemac requested review from Copilot and dataflake November 28, 2025 07:53
@icemac icemac self-assigned this Nov 28, 2025
@icemac icemac enabled auto-merge (squash) November 28, 2025 07:54
Copilot finished reviewing on behalf of icemac November 28, 2025 07:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates package metadata from setup.py to pyproject.toml, following modern Python packaging standards. The setup.py file is reduced to a minimal shim that calls setup() without arguments, with all configuration now centralized in pyproject.toml.

Key changes:

  • Converted all package metadata (name, version, dependencies, entry points, etc.) from setup.py to pyproject.toml format
  • Updated copyright year to 2024-2025 in setup.py
  • Added changelog entry documenting the migration

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

File Description
setup.py Simplified to minimal shim with setup() call, removed all metadata definitions, updated copyright year
pyproject.toml Added complete [project] section with all metadata from setup.py including dependencies, entry points, and URLs
CHANGES.rst Added changelog entry documenting the metadata migration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

The script itself has corrections in
57a1183 and
d4a718f
@coveralls
Copy link

coveralls commented Nov 28, 2025

Pull Request Test Coverage Report for Build 19761819258

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 15.077%

Totals Coverage Status
Change from base Build 19758706061: 0.0%
Covered Lines: 240
Relevant Lines: 1203

💛 - Coveralls

@dataflake
Copy link
Member

dataflake commented Nov 28, 2025

@icemac That Copilot review was a mixed bag, some good catches (all fixed right on master) and some items that were just plain wrong.

The only open comment is about setting the readme value to just README.rst. The suggestion to use the [tool.setuptools.dynamic] table to specify more than one file makes sense, BUT I'd need to try and parse the actual file names out of an unstructured text blob that is constructed in different ways across all the packages. I would like to avoid that. Instead, I should be able to do something like this:

  • find correct README filename (this check already exists)
  • find a change log filename (test either CHANGES.rst or CHANGES.txt)
  • if there's just a README, leave the readme setting in [project]
  • if both can be found, move the readme setting into [tool.setuptools.dynamic] and use both files.

@dataflake
Copy link
Member

I have now applied the changed readme value generation from PR #373

@icemac icemac merged commit 1178440 into master Nov 28, 2025
13 checks passed
@icemac icemac deleted the convert-setup-py-to-pyproject-toml branch November 28, 2025 11:01
@icemac
Copy link
Member Author

icemac commented Dec 1, 2025

@dataflake Thank you for reviewing and fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants