manifest: Update nrf_wifi #81514

karun2796 · 2024-11-18T11:43:24Z

Updated manifest to include separate security type for EAP TLS SHA256 in display of scan results when APs have EAP and PMF enabled.

zephyrbot · 2024-11-18T11:44:25Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
nrf_wifi	zephyrproject-rtos/nrf_wifi@`71261e2`	zephyrproject-rtos/nrf_wifi@`f6b950a` (`main`)	zephyrproject-rtos/[email protected]

Additional metadata changed:

Name	URL	Submodules	West cmds	`module.yml`
nrf_wifi				✏

⛔ DNM label due to: 1 project with metadata changes

Note: This message is automatically posted and updated by the Manifest GitHub Action.

Updated manifest to include separate security types for 802.1X in display of scan results when APs have EAP and PMF enabled. BSS display limit based on user-configured non-zero values set via CMD_INIT, along with support for few other regulatory domain updates in firmware. Upstream PR: zephyrproject-rtos/zephyr#81514 Signed-off-by: Karun Kumar Eagalapati <[email protected]>

EAP_TLS_SHA256 was being identified as EAP_TLS in display scan results. Identify the security type in scan results sent by RPU and display accordingly. Upstream PR: zephyrproject-rtos/zephyr#81514 Signed-off-by: Ravi Dondaputi <[email protected]>

Expand the security modes identified in the display-scan results. Add appropriate strings for corresponding enumerations. Upstream PR: zephyrproject-rtos/zephyr#81514 Signed-off-by: Ravi Dondaputi <[email protected]>

include/zephyr/net/wifi.h

Updated manifest to include separate security types for 802.1X in display of scan results when APs have EAP and PMF enabled. BSS display limit based on user-configured non-zero values set via CMD_INIT, along with support for few other regulatory domain updates in firmware. Signed-off-by: Karun Kumar Eagalapati <[email protected]>

EAP_TLS_SHA256 was being identified as EAP_TLS in display scan results. Identify the security type in scan results sent by RPU and display accordingly. Signed-off-by: Ravi Dondaputi <[email protected]>

Expand the security modes identified in the display-scan results. Add appropriate strings for corresponding enumerations. Signed-off-by: Ravi Dondaputi <[email protected]>

krish2718 · 2024-12-04T16:50:20Z

drivers/wifi/nrf_wifi/src/wifi_mgmt_scan.c

+	case NRF_WIFI_OPEN:
+	case NRF_WIFI_WEP:
+	case NRF_WIFI_WPA:
+	case NRF_WIFI_WPA2:
+	case NRF_WIFI_WPA2_256:
+	case NRF_WIFI_WPA3:
+	case NRF_WIFI_WAPI:
+	case NRF_WIFI_FT_EAP_SHA384:
+	case NRF_WIFI_FT_PSK_SHA384:
+	case NRF_WIFI_PSK_SHA384:
+		return WIFI_CIPHER_SUITE_B_NA;


These can be removed as default is NA

krish2718 · 2024-12-04T16:50:44Z

include/zephyr/net/wifi.h

 extern "C" {
 #endif

+/** @brief IEEE 802.11 SUITE-B */


Suggested change

/** @brief IEEE 802.11 SUITE-B */

/** @brief NSA SUITE-B crypto suites */

krish2718 · 2024-12-04T16:51:49Z

subsys/net/l2/wifi/wifi_mgmt.c

 const char *wifi_security_txt(enum wifi_security_type security)
 {
+	if (is_enterprise_security(security)) {
+		return "IEEE_8021_x";


Suggested change

return "IEEE_8021_x";

return "8021.x";

MaochenWang1 · 2024-12-05T02:56:52Z

FYI @Rex-Chen-NXP

Rex-Chen-NXP · 2024-12-05T03:16:41Z

include/zephyr/net/wifi.h

 #endif

+/** @brief IEEE 802.11 SUITE-B */
+enum wifi_cipher_suite_b {


Could you make it align with 'enum wifi_suiteb_type', then remove one of those to avoid duplicate implementation.

Rex-Chen-NXP · 2024-12-05T03:18:56Z

subsys/net/l2/wifi/wifi_mgmt.c

 static struct wifi_roaming_params roaming_params;
 #endif

+const bool is_enterprise_security(enum wifi_security_type security)


similar with function is_eap_valid_security, pls move one of them to avoid duplicate impl

Rex-Chen-NXP · 2024-12-05T03:20:59Z

subsys/net/l2/wifi/wifi_mgmt.c

 		return "WPA/WPA2/WPA3 PSK";
 	case WIFI_SECURITY_TYPE_DPP:
 		return "DPP";
-	case WIFI_SECURITY_TYPE_EAP_PEAP_MSCHAPV2:


why delete those types?

MaochenWang1 · 2024-12-05T05:44:45Z

drivers/wifi/nrf_wifi/src/wifi_mgmt_scan.c

+	case NRF_WIFI_EAP:
+	case NRF_WIFI_EAP_TLS_SHA256:
+	case NRF_WIFI_FT_EAP:
+		return WIFI_CIPHER_SUITE_B_NONE;


How to distinguish WIFI_CIPHER_SUITE_B_NA and WIFI_CIPHER_SUITE_B_NONE?
Why NRF_WIFI_FT_EAP_SHA384 belongs to WIFI_CIPHER_SUITE_B_NA?

github-actions · 2025-02-04T00:33:18Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

github-actions · 2025-04-06T00:39:17Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

karun2796 · 2025-04-17T07:07:18Z

Closing this as it's merged to ncs through another PR

zephyrbot added the size: XS A PR changing only a single line of code label Nov 18, 2024

zephyrbot added manifest manifest-hal_nordic DNM This PR should not be merged (Do Not Merge) labels Nov 18, 2024

rado17 force-pushed the EAP_TLS_UPSTREAM branch from bdf0f05 to 3507aab Compare November 20, 2024 10:29

zephyrbot added the area: Wi-Fi Wi-Fi label Nov 20, 2024

zephyrbot requested review from Kludentwo, jukkar, krish2718, rlubos and sachinthegreen November 20, 2024 10:29

zephyrbot assigned jukkar Nov 20, 2024

rlubos previously approved these changes Nov 20, 2024

View reviewed changes

jukkar previously approved these changes Nov 20, 2024

View reviewed changes

sachinthegreen previously approved these changes Nov 25, 2024

View reviewed changes

karun2796 dismissed stale reviews from sachinthegreen, jukkar, and rlubos via 982861f November 29, 2024 08:19

karun2796 force-pushed the EAP_TLS_UPSTREAM branch from 3507aab to 982861f Compare November 29, 2024 08:19

zephyrbot requested a review from MaochenWang1 November 29, 2024 08:20

zephyrbot added the manifest-nrf_wifi label Nov 29, 2024

karun2796 changed the title ~~manifest: Update hal_nordic~~ manifest: Update nrf_wifi Nov 29, 2024

karun2796 force-pushed the EAP_TLS_UPSTREAM branch from 982861f to 1e5d689 Compare November 29, 2024 10:09

zephyrbot added the area: Networking label Dec 2, 2024

krish2718 reviewed Dec 3, 2024

View reviewed changes

include/zephyr/net/wifi.h Outdated Show resolved Hide resolved

MaochenWang1 requested changes Dec 4, 2024

View reviewed changes

include/zephyr/net/wifi.h Outdated Show resolved Hide resolved

rado17 force-pushed the EAP_TLS_UPSTREAM branch from 5392c6c to 61508ab Compare December 4, 2024 12:08

kspraveeen force-pushed the EAP_TLS_UPSTREAM branch from 61508ab to 3f6c563 Compare December 4, 2024 12:27

rado17 force-pushed the EAP_TLS_UPSTREAM branch from 3f6c563 to 3f42556 Compare December 4, 2024 12:34

krish2718 previously approved these changes Dec 4, 2024

View reviewed changes

krish2718 requested a review from MaochenWang1 December 4, 2024 12:38

rado17 dismissed krish2718’s stale review via 04f4ec7 December 4, 2024 12:43

rado17 force-pushed the EAP_TLS_UPSTREAM branch from 3f42556 to 04f4ec7 Compare December 4, 2024 12:43

kspraveeen force-pushed the EAP_TLS_UPSTREAM branch from 04f4ec7 to a124830 Compare December 4, 2024 16:48

karun2796 and others added 3 commits December 4, 2024 22:19

nrfwifi: Display EAP_TLS_SHA256 security in scan results

02107db

EAP_TLS_SHA256 was being identified as EAP_TLS in display scan results. Identify the security type in scan results sent by RPU and display accordingly. Signed-off-by: Ravi Dondaputi <[email protected]>

net: wifi: Expand security enumeration for scan display

3428a11

Expand the security modes identified in the display-scan results. Add appropriate strings for corresponding enumerations. Signed-off-by: Ravi Dondaputi <[email protected]>

kspraveeen force-pushed the EAP_TLS_UPSTREAM branch from a124830 to 3428a11 Compare December 4, 2024 16:49

krish2718 reviewed Dec 4, 2024

View reviewed changes

Rex-Chen-NXP reviewed Dec 5, 2024

View reviewed changes

MaochenWang1 reviewed Dec 5, 2024

View reviewed changes

github-actions bot added the Stale label Feb 4, 2025

fabiobaltieri added DNM (manifest) This PR should not be merged (controlled by action-manifest) and removed DNM This PR should not be merged (Do Not Merge) labels Feb 4, 2025

github-actions bot removed the Stale label Feb 5, 2025

github-actions bot added the Stale label Apr 6, 2025

karun2796 closed this Apr 17, 2025

	/** @brief IEEE 802.11 SUITE-B */
	/** @brief NSA SUITE-B crypto suites */

manifest: Update nrf_wifi #81514

manifest: Update nrf_wifi #81514

Uh oh!

Conversation

karun2796 commented Nov 18, 2024

Uh oh!

zephyrbot commented Nov 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

krish2718 Dec 4, 2024

Choose a reason for hiding this comment

Uh oh!

krish2718 Dec 4, 2024

Choose a reason for hiding this comment

Uh oh!

krish2718 Dec 4, 2024

Choose a reason for hiding this comment

Uh oh!

MaochenWang1 commented Dec 5, 2024

Uh oh!

Rex-Chen-NXP Dec 5, 2024

Choose a reason for hiding this comment

Uh oh!

Rex-Chen-NXP Dec 5, 2024

Choose a reason for hiding this comment

Uh oh!

Rex-Chen-NXP Dec 5, 2024

Choose a reason for hiding this comment

Uh oh!

MaochenWang1 Dec 5, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 4, 2025

Uh oh!

github-actions bot commented Apr 6, 2025

Uh oh!

karun2796 commented Apr 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

zephyrbot commented Nov 18, 2024 •

edited

Loading