This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Add route match params to request attributes #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgrim
force-pushed
the
add-route-match-params-to-request-attributes
branch
from
9abe66e to
79fe956
Compare
Contributor
|
Looks good to me. |
Member
michalbundyra
left a comment
michalbundyra
left a comment
There was a problem hiding this comment.
I think would be also nice inject whole RouteMatch, not only individual matched params (as we have it in expressive).
| try { | ||
| $return = $middleware(Psr7Request::fromZend($request), Psr7Response::fromZend($response)); | ||
| $psr7Request = Psr7Request::fromZend($request); | ||
| foreach ($routeMatch->getParams() as $key => $value) { |
Member
There was a problem hiding this comment.
I think will be nice to inject also while RouteMatch (as we have it in expressive: https://github.com/zendframework/zend-expressive/blob/master/src/Application.php#L431-L435), not just individual matched params.
test/MiddlewareListenerTest.php
Outdated
| $listener = new MiddlewareListener(); | ||
| $return = $listener->onDispatch($event); | ||
| self::assertInstanceOf(Response::class, $return); | ||
| self::assertSame($matchedRouteParam, $return->getBody()); |
Member
There was a problem hiding this comment.
Please use $this-> (instead of self::) in 2 above assertions to keep consistency with other tests.
weierophinney
approved these changes
Dec 20, 2016
Member
weierophinney
left a comment
weierophinney
left a comment
There was a problem hiding this comment.
Patch looks quite reasonable, and makes the support within middleware more on par with that in MVC controllers. 👍
akrabat
added a commit
that referenced
this pull request
Dec 20, 2016
…-attributes Add route match params to request attributes
akrabat
added a commit
that referenced
this pull request
Dec 20, 2016
akrabat
added a commit
that referenced
this pull request
Dec 20, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change copies the
RouteMatchparameters into the PSR-7\Zend\Diactoros\ServerRequestso that they may be referred to in a middleware that has been invoked by theMiddlewareListener. Currently, if using a middleware in this way, I don't see any other way to access the matched route information (specifically, matched route parameters from a segment route, e.g./:uuidmatches, but I can't access theuuidparameter anywhere in the middleware action).