feat!: error early on changes to zarf services during a subsequent init #4161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Abro <[email protected]>
✅ Deploy Preview for zarf-docs canceled.
|
Signed-off-by: Austin Abro <[email protected]>
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
AustinAbro321
changed the title
Signed-off-by: Austin Abro <[email protected]>
…zarf into error-early-on-service-changes
mkcp
approved these changes
Sep 10, 2025
| @@ -265,17 +265,6 @@ func (c *Cluster) InitState(ctx context.Context, opts InitStateOptions) (*state. | |||
| s.RegistryInfo = opts.RegistryInfo | |||
| opts.ArtifactServer.FillInEmptyValues() | |||
| s.ArtifactServer = opts.ArtifactServer | |||
| } else { | |||
| // TODO (@austinabro321) validate immediately in `zarf init` if these are set and not equal and error out if so | |||
AustinAbro321
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Something that has confused many users is that if they try to change their registry credentials on a subsequent init, it will not work. They do get an error message, but it can be easily missed, and so it's better to return early and force the user to either use
zarf tools update-credsor not call the command with flags that won't workRelated Issue
Fixes #3189
Relates to #4160
Checklist before merging