Skip to content

Conversation

AustinAbro321
Copy link
Contributor

@AustinAbro321 AustinAbro321 commented Aug 6, 2025

Description

The test in progress_test.go has flaked several times as of late, see https://github.com/zarf-dev/zarf/actions/runs/16759926068/job/47452261385. Time based tests look to not be consistent, they likely could be if we extended the time the test took, but that still could be subject to the same issue, or make the test take too long. Another option could be to dependency injection on the timer to allow a mock, but I feel it is not worth it in this case given the simple behavior under test.

Checklist before merging

Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321 AustinAbro321 requested review from a team as code owners August 6, 2025 12:14
Copy link

netlify bot commented Aug 6, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit c1c5d95
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/68934712f2f0e30008fa3e0e

Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understandable - shared systems like ci can halt or slowdown arbitrarily which makes timing problems worse. lgtm

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit df0ce1b Aug 6, 2025
27 checks passed
@AustinAbro321 AustinAbro321 deleted the remove-flaky-test branch August 6, 2025 15:06
Ansible-man pushed a commit to Ansible-man/zarf that referenced this pull request Sep 6, 2025
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Cade Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants