Skip to content

Conversation

mkcp
Copy link
Contributor

@mkcp mkcp commented Jun 30, 2025

Description

This PR is intended to address a new linter rule that popped up in latest golangci-lint, v2.2.1. "meaningless" package names like util, types, etc. are now flagged as a code smell / linter rule error. As much as I'd agree with this, it's an intentional and managed decision in the Zarf codebase at the moment. This PR adds an ignore rule for package names, with the intent to remove it in the future when we're done breaking types and utils out into packages with more meaningful names.

I did try specific allowlist rules for types and utils but the linter error kept flagging so maybe the allowlist doesn't work for packages? Either way, skipPackageNameChecks: true solves the issue locally.

Related Issue

Checklist before merging

@mkcp mkcp self-assigned this Jun 30, 2025
@mkcp mkcp requested review from a team as code owners June 30, 2025 18:25
@mkcp mkcp added bug 🐞 Something isn't working github_actions Pull requests that update GitHub Actions code labels Jun 30, 2025
Copy link

netlify bot commented Jun 30, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 9cbe44e
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/6862d6a53e26a90008c496bf

Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mkcp mkcp enabled auto-merge June 30, 2025 18:37
@mkcp mkcp added this pull request to the merge queue Jun 30, 2025
Merged via the queue into main with commit f5e22a9 Jun 30, 2025
27 checks passed
@mkcp mkcp deleted the fix-golangci-v2.2.1-linter branch June 30, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants