fix: exempt packages from revive var-naming linter #3953
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is intended to address a new linter rule that popped up in latest golangci-lint, v2.2.1. "meaningless" package names like util, types, etc. are now flagged as a code smell / linter rule error. As much as I'd agree with this, it's an intentional and managed decision in the Zarf codebase at the moment. This PR adds an ignore rule for package names, with the intent to remove it in the future when we're done breaking types and utils out into packages with more meaningful names.
I did try specific allowlist rules for
types
andutils
but the linter error kept flagging so maybe the allowlist doesn't work for packages? Either way,skipPackageNameChecks: true
solves the issue locally.Related Issue
Checklist before merging