Skip to content

Conversation

phillebaba
Copy link
Contributor

Description

This change refactors the deprecation migration and adds unit tests.

Related Issue

Relates to #2969

Checklist before merging

@phillebaba phillebaba requested review from a team as code owners November 25, 2024 17:46
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 98a302b
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6744b81f55ac8a000800845a

@phillebaba phillebaba changed the title Refactor refactor migrate deprecated Refactor migrate deprecated Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 94.02985% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager2/layout/deprecated.go 93.98% 6 Missing and 2 partials ⚠️
Files with missing lines Coverage Δ
src/internal/packager2/layout/create.go 56.77% <ø> (-1.10%) ⬇️
src/internal/packager2/layout/layout.go 62.50% <100.00%> (-10.23%) ⬇️
src/internal/packager2/layout/deprecated.go 93.98% <93.98%> (ø)

Copy link
Contributor

@AustinAbro321 AustinAbro321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job simplifying and adding tests

@phillebaba phillebaba added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit f36414b Dec 2, 2024
26 checks passed
@phillebaba phillebaba deleted the refactor/deprecated branch December 2, 2024 18:41
nevinaragam pushed a commit to nevinaragam/zarf that referenced this pull request May 20, 2025
Signed-off-by: Philip Laine <[email protected]>
Signed-off-by: NevinAragam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants