Skip to content

Conversation

@CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Dec 23, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Old name New name
--materialize-indexes --include-index-data
--index-filling-mode --index-population-mode

@ydbot
Copy link
Collaborator

ydbot commented Dec 23, 2025

Run Extra Tests

Run additional tests for this PR. You can customize:

  • Test Size: small, medium, large (default: all)
  • Test Targets: any directory path (default: ydb/)
  • Sanitizers: ASAN, MSAN, TSAN
  • Coredumps: enable for debugging (default: off)
  • Additional args: custom ya make arguments

▶  Run tests

@github-actions
Copy link

github-actions bot commented Dec 23, 2025

🟢 2025-12-23 16:53:44 UTC The validation of the Pull Request description is successful.

@github-actions

This comment was marked as outdated.

@CyberROFL CyberROFL marked this pull request as ready for review December 23, 2025 16:38
@CyberROFL CyberROFL requested review from a team as code owners December 23, 2025 16:38
@CyberROFL CyberROFL self-assigned this Dec 23, 2025
@github-actions

This comment was marked as outdated.

spuchin
spuchin previously approved these changes Dec 23, 2025
Gazizonoki
Gazizonoki previously approved these changes Dec 23, 2025
Copy link
Collaborator

@Gazizonoki Gazizonoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDK lgtm

@CyberROFL CyberROFL dismissed stale reviews from Gazizonoki and spuchin via 99183dd December 23, 2025 16:53
@github-actions
Copy link

github-actions bot commented Dec 23, 2025

2025-12-23 16:54:48 UTC Pre-commit check linux-x86_64-release-asan for 998789a has started.
2025-12-23 16:56:36 UTC Artifacts will be uploaded here
2025-12-23 16:58:27 UTC ya make is running...
🟡 2025-12-23 18:41:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16546 16448 0 56 24 18

🟢 2025-12-23 18:41:38 UTC Build successful.
🟢 2025-12-23 18:42:07 UTC ydbd size 3.8 GiB changed* by -136 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 09f1cae merge: 998789a diff diff %
ydbd size 4 086 795 328 Bytes 4 086 795 192 Bytes -136 Bytes -0.000%
ydbd stripped size 1 530 347 384 Bytes 1 530 347 320 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL requested a review from pnv1 December 23, 2025 16:54
@github-actions
Copy link

github-actions bot commented Dec 23, 2025

2025-12-23 16:56:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for 998789a has started.
2025-12-23 16:57:17 UTC Artifacts will be uploaded here
2025-12-23 16:59:27 UTC ya make is running...
🟡 2025-12-23 19:33:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
46317 42714 0 184 3383 36

2025-12-23 19:33:37 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-12-23 20:10:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1875 (only retried tests) 1862 0 1 0 12

2025-12-23 20:10:59 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-12-23 20:20:55 UTC Some tests failed, follow the links below.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1205 (only retried tests) 1192 0 1 0 12

🟢 2025-12-23 20:21:02 UTC Build successful.
🟢 2025-12-23 20:21:29 UTC ydbd size 2.3 GiB changed* by -104 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 09f1cae merge: 998789a diff diff %
ydbd size 2 486 521 800 Bytes 2 486 521 696 Bytes -104 Bytes -0.000%
ydbd stripped size 529 311 712 Bytes 529 311 712 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Collaborator

@pnv1 pnv1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI part LGTM

@CyberROFL CyberROFL enabled auto-merge (squash) December 23, 2025 17:10
@maximyurchuk maximyurchuk merged commit 9f65709 into ydb-platform:main Dec 24, 2025
6 of 9 checks passed
@ydbot
Copy link
Collaborator

ydbot commented Dec 24, 2025

Backport

To backport this PR, click the button next to the target branch and then click "Run workflow" in the Run Actions UI.

Branch Run
stable-25-2, stable-25-2-1, stable-25-3, stable-25-3-1 ▶  Backport
stable-25-3, stable-25-3-1 ▶  Backport
stable-25-3 ▶  Backport

▶  Backport manual

@CyberROFL CyberROFL deleted the rename branch December 24, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

👑 Materialize indexes in exports and imports

7 participants