Skip to content

Conversation

@adameat
Copy link
Member

@adameat adameat commented Dec 23, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@adameat adameat self-assigned this Dec 23, 2025
Copilot AI review requested due to automatic review settings December 23, 2025 12:20
@github-actions
Copy link

github-actions bot commented Dec 23, 2025

2025-12-23 12:21:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5e19c8e has started.
2025-12-23 12:21:57 UTC Artifacts will be uploaded here
2025-12-23 12:24:05 UTC ya make is running...
2025-12-23 14:11:35 UTC Check cancelled

@ydbot
Copy link
Collaborator

ydbot commented Dec 23, 2025

Run Extra Tests

Run additional tests for this PR. You can customize:

  • Test Size: small, medium, large (default: all)
  • Test Targets: any directory path (default: ydb/)
  • Sanitizers: ASAN, MSAN, TSAN
  • Coredumps: enable for debugging (default: off)
  • Additional args: custom ya make arguments

▶  Run tests

@github-actions
Copy link

🟢 2025-12-23 12:24:39 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Dec 23, 2025

2025-12-23 12:24:42 UTC Pre-commit check linux-x86_64-release-asan for 5e19c8e has started.
2025-12-23 12:24:59 UTC Artifacts will be uploaded here
2025-12-23 12:27:09 UTC ya make is running...
🟡 2025-12-23 14:05:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15487 15260 0 121 83 23

🟢 2025-12-23 14:05:57 UTC Build successful.
🟢 2025-12-23 14:06:30 UTC ydbd size 3.8 GiB changed* by +25.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 32b9546 merge: 5e19c8e diff diff %
ydbd size 4 086 616 408 Bytes 4 086 642 944 Bytes +25.9 KiB +0.001%
ydbd stripped size 1 530 291 544 Bytes 1 530 302 360 Bytes +10.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves distributed tracing support in the HTTP cache actors by integrating Wilson tracing spans. The changes enable request tracing through cache layers by propagating trace context via OpenTelemetry-compatible headers and tracking cache operations as trace spans.

Key changes:

  • Added Wilson tracing span support to both incoming and outgoing HTTP cache actors
  • Modified Duplicate() methods across HTTP request/response classes to accept optional extra headers for trace propagation
  • Extended StatusSuccess() to include 1xx responses in addition to 2xx responses

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
ydb/library/actors/http/http_cache.cpp Added Wilson tracing integration with SetupTracing methods, TRequest structs bundling requests with spans, span lifecycle management throughout cache operations, and trace header propagation
ydb/library/actors/http/http.h Updated Duplicate method signatures to accept optional extraHeaders parameter; made THttpIncomingRequest::Duplicate const-correct
ydb/library/actors/http/http.cpp Reimplemented Duplicate methods to rebuild HTTP messages from scratch while merging extra headers, enabling proper trace header injection

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@maximyurchuk maximyurchuk added the rebase-and-check Rebase PR with the current base branch and check label Dec 23, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Dec 23, 2025
@github-actions
Copy link

github-actions bot commented Dec 23, 2025

2025-12-23 14:12:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3721e81 has started.
2025-12-23 14:13:18 UTC Artifacts will be uploaded here
2025-12-23 14:15:22 UTC ya make is running...
🟡 2025-12-23 16:42:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
45951 42363 0 183 3378 27

2025-12-23 16:42:44 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-12-23 17:15:43 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1839 (only retried tests) 1828 0 0 0 11

🟢 2025-12-23 17:15:49 UTC Build successful.
🟢 2025-12-23 17:16:14 UTC ydbd size 2.3 GiB changed* by +11.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 54d3846 merge: 3721e81 diff diff %
ydbd size 2 486 506 360 Bytes 2 486 517 624 Bytes +11.0 KiB +0.000%
ydbd stripped size 529 305 024 Bytes 529 305 728 Bytes +704 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Dec 23, 2025

2025-12-23 14:15:13 UTC Pre-commit check linux-x86_64-release-asan for 3721e81 has started.
2025-12-23 14:15:32 UTC Artifacts will be uploaded here
2025-12-23 14:17:40 UTC ya make is running...
🟡 2025-12-23 15:59:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15249 15149 0 68 18 14

🟢 2025-12-23 15:59:47 UTC Build successful.
🟢 2025-12-23 16:00:19 UTC ydbd size 3.8 GiB changed* by +25.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 54d3846 merge: 3721e81 diff diff %
ydbd size 4 086 771 216 Bytes 4 086 797 672 Bytes +25.8 KiB +0.001%
ydbd stripped size 1 530 337 880 Bytes 1 530 348 632 Bytes +10.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat enabled auto-merge (squash) December 24, 2025 04:53
@adameat adameat merged commit 5df9185 into ydb-platform:main Dec 24, 2025
20 of 22 checks passed
@ydbot
Copy link
Collaborator

ydbot commented Dec 24, 2025

Backport

To backport this PR, click the button next to the target branch and then click "Run workflow" in the Run Actions UI.

Branch Run
stable-25-2, stable-25-2-1, stable-25-3, stable-25-3-1 ▶  Backport
stable-25-3, stable-25-3-1 ▶  Backport
stable-25-3 ▶  Backport

▶  Backport manual

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants