-
Notifications
You must be signed in to change notification settings - Fork 740
improve tracing #31192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve tracing #31192
Conversation
|
🟢 |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR improves distributed tracing support in the HTTP cache actors by integrating Wilson tracing spans. The changes enable request tracing through cache layers by propagating trace context via OpenTelemetry-compatible headers and tracking cache operations as trace spans.
Key changes:
- Added Wilson tracing span support to both incoming and outgoing HTTP cache actors
- Modified
Duplicate()methods across HTTP request/response classes to accept optional extra headers for trace propagation - Extended
StatusSuccess()to include 1xx responses in addition to 2xx responses
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ydb/library/actors/http/http_cache.cpp | Added Wilson tracing integration with SetupTracing methods, TRequest structs bundling requests with spans, span lifecycle management throughout cache operations, and trace header propagation |
| ydb/library/actors/http/http.h | Updated Duplicate method signatures to accept optional extraHeaders parameter; made THttpIncomingRequest::Duplicate const-correct |
| ydb/library/actors/http/http.cpp | Reimplemented Duplicate methods to rebuild HTTP messages from scratch while merging extra headers, enabling proper trace header injection |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
...
Changelog category
Description for reviewers
...