Move shared constants to dedicated file #1991
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qrort
force-pushed
the
node-hint-metric-improve
branch
from
f0557dd to
049723b
Compare
Co-authored-by: asmyasnikov <[email protected]>
Copilot
AI
changed the title
[WIP] WIP address feedback on node_hint metrics improvements
Move shared constants to dedicated file
Dec 19, 2025
qrort
force-pushed
the
node-hint-metric-improve
branch
3 times, most recently
from
7f12ad2 to
3092b0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses code organization feedback from #1990 where
trueStrandfalseStrconstants were defined inquery.gobut used in bothquery.goandtable.go, creating an implicit cross-file dependency.Changes:
metrics/constants.goto house shared package-level constantsquery.goBoth files now explicitly reference constants from the dedicated location rather than relying on same-package visibility from an arbitrary source file.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.