Skip to content

test: add a new test case for global cache #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Jun 2, 2025

No description provided.

@JounQin JounQin changed the title chore: reproduce global cache issue test: add a new test case for global cache Jun 2, 2025
@JounQin JounQin force-pushed the repro/global-cache branch 8 times, most recently from 2e881ab to 504e487 Compare June 2, 2025 20:16
@JounQin
Copy link
Contributor Author

JounQin commented Jun 2, 2025

https://github.com/yarnpkg/pnp-rs/actions/runs/15409138112/job/43357484921?pr=10#step:6:162

manifest.manifest_dir, D:\a\pnp-rs\pnp-rs\fixtures\global-cache
package_location: D:\a\pnp-rs\pnp-rs\fixtures\global-cache\../../../../../../C:/Users/runneradmin/AppData/Local/Yarn/Berry/cache/source-map-support-npm-0.5.21-09ca99e250-10c0.zip/node_modules/source-map-support/
normalized_location: C:Users/runneradmin/AppData/Local/Yarn/Berry/cache/source-map-support-npm-0.5.21-09ca99e250-10c0.zip/node_modules/source-map-support/
info.package_location: C:Users/runneradmin/AppData/Local/Yarn/Berry/cache/source-map-support-npm-0.5.21-09ca99e250-10c0.zip/node_modules/source-map-support/

Windows compatibility is bad...

cc @arcanis

@JounQin JounQin force-pushed the repro/global-cache branch from 504e487 to a3f6908 Compare June 3, 2025 05:16
@JounQin JounQin force-pushed the repro/global-cache branch from a3f6908 to d246536 Compare June 3, 2025 05:19
JounQin added a commit to unrs/unrs-resolver that referenced this pull request Jun 3, 2025
Windows global cache is still unsupported due to upstream

see also yarnpkg/pnp-rs#10
@arcanis
Copy link
Member

arcanis commented Jun 3, 2025

Thanks! I'm looking into that.

@JounQin
Copy link
Contributor Author

JounQin commented Jun 10, 2025

@arcanis Is there anything I can help to support Windows?

@arcanis
Copy link
Member

arcanis commented Jun 10, 2025

My issue is mostly time at the moment - I'm working in parallel on a major Yarn refactoring, and coupled with regular work being intense I didn't get a chance to look at Windows yet.

I gladly accept contributions around it, although I don't want you to feel pressured into doing it - I still want to eventually address it myself if I'm not beat to the punch, although I don't have an exact timeline right now.

Design-wise, in Yarn we solved that by always treating all paths as posix, normalizing Windows path into posix internally (/c/foo) and only converting them back into Windows-style paths right as they were returned by the public api.

I wanted to try that but, while it worked fine for a full application, it feels a little overkill for a library... 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants