Introduce opt-in glyph scaling to achieve GB18030 compliance #4997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4969
I've tried to keep the overhead for the webgl renderer as small as possible, there's just a check for an option (via optimized
rawOptions) and fetching the width of each cell fromcontent.Webgl with the setting off:
Webgl with the setting on:
I looked into dynamically resizing based on the following glyph but it ended up feeling weird seeing the glyphs change. The VIII in particular seems pretty hard to read which is probably a combination of letting the GPU handle interpolation (good for perf but it might be using nearest pixel?) and it tries to pack a lot of stuff into a small cell on a standard DPI screen (high DPI would be fine).
The setting is opt-in in xterm.js and the plan is to enable it by default in VS Code.