Skip to content

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Sep 10, 2023

I'm hoping this will reduce flakiness, in particular this issue that can happen sometimes:

1) [Firefox Stable] › ../../test/playwright/CharWidth.test.ts:20:9 › CharWidth Integration Tests › getStringCellWidth › ASCII chars 

    "beforeAll" hook timeout of 10000ms exceeded.

       8 |
       9 | let ctx: ITestContext;
    > 10 | test.beforeAll(async ({ browser }) => {
         |      ^
      11 |   ctx = await createTestContext(browser);
      12 |   await openTerminal(ctx);
      13 | });

        at /home/runner/work/xterm.js/xterm.js/test/playwright/CharWidth.test.ts:10:6

This also speeds up tests by using more cores on high core machines.

@Tyriar Tyriar added this to the 5.4.0 milestone Sep 10, 2023
@Tyriar Tyriar self-assigned this Sep 10, 2023
@Tyriar Tyriar enabled auto-merge September 10, 2023 15:58
@Tyriar Tyriar merged commit b2c123e into xtermjs:master Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant